Closed Bug 1638982 Opened 4 months ago Closed 4 months ago

Convert 'mach remote' to run with Python 3

Categories

(Remote Protocol :: Agent, task, P1)

Tracking

(firefox78 fixed)

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: KrisWright, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

mach remote still runs with python 2 [1]. We want to convert all mach commands to python 3.

To do this, any dependencies of the command may need to be converted as well as the command itself.

[1] https://searchfox.org/mozilla-central/rev/9193635dca8cfdcb68f114306194ffc860456044/remote/mach_commands.py

Kris, what specifically needs to be done to make it Python 3 compatible? It would be great to get some instructions what needs to be done. If ot here maybe on the meta bug.

Flags: needinfo?(kwright)

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #1)

Kris, what specifically needs to be done to make it Python 3 compatible? It would be great to get some instructions what needs to be done. If ot here maybe on the meta bug.

I'm not super familiar with the process we're using, so I'll divert this to Ricky. Maybe there is a guide or some tips that we can put on the metabug as well?

Flags: needinfo?(kwright) → needinfo?(rstewart)

Yeah, let me try to throw up some basic guidance on the metabug. Gimme a bit, I'll report back when that's done.

I updated the user story on the metabug. Please have a look and let me know if there are any improvements I can make or additional questions you have (this is all just off the top of my head).

Flags: needinfo?(rstewart)

Thanks Ricky! As it looks like there is nothing to do here for that specific mach command. The sub command vendor-puppeteer works just fine when it is run with Python 3.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P1

This aligns our code with other mach commands that don't
show the command usage if no subcommand has been specified.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a54634147e5
[remote] Remove custom usage output for the remote command. r=remote-protocol-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/3a73bf75d1ce
[remote] Convert 'mach remote' to run with Python 3 r=rstewart,remote-protocol-reviewers,jgraham
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.