1638993 - Convert 'mach test-info' to run with Python 3

Status: RESOLVED FIXED

(Testing :: General, task, P2)

Description

[Kris Wright :KrisWright]

mach test-info still runs with python 2 [1]. We want to convert all mach commands to python 3.

To do this, any dependencies of the command may need to be converted as well as the command itself.

[1] https://searchfox.org/mozilla-central/rev/9193635dca8cfdcb68f114306194ffc860456044/testing/mach_commands.py

Comment 1

[Geoff Brown [:gbrown]]

Currently this fails in moztest (TestResolver):

TypeError: '<' not supported between instances of 'dict' and 'dict'

  File "/home/gbrown/src/testing/mach_commands.py", line 698, in test_info_tests
    show_info, show_results, show_durations, show_tasks, show_bugs)
  File "/home/gbrown/src/testing/testinfo.py", line 462, in report
    self.set_test_name()
  File "/home/gbrown/src/testing/testinfo.py", line 163, in set_test_name
    tests = list(resolver.resolve_tests(paths=[relpath]))
  File "/home/gbrown/src/testing/mozbase/moztest/moztest/resolve.py", line 836, in resolve_tests
    for test in self._resolve(**kwargs):
  File "/home/gbrown/src/testing/mozbase/moztest/moztest/resolve.py", line 624, in _resolve
    if (path in self.test_dirs or
  File "/home/gbrown/src/testing/mozbase/moztest/moztest/resolve.py", line 543, in test_dirs
    for test in self.tests:
  File "/home/gbrown/src/testing/mozbase/moztest/moztest/resolve.py", line 513, in tests
    for test in self.load_tests():
  File "/home/gbrown/src/testing/mozbase/moztest/moztest/resolve.py", line 466, in __call__
    for test in tests:
  File "/home/gbrown/src/testing/mozbase/moztest/moztest/resolve.py", line 452, in _load_reftest_manifest
    for test in sorted(manifest.tests):

Comment 2

[Geoff Brown [:gbrown]]

(In reply to Geoff Brown [:gbrown] from comment #1)
This seems to be expected: https://stackoverflow.com/questions/55695479/typeerror-not-supported-between-instances-of-dict-and-dict.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: Bug 1638993 - Run 'mach test-info' with python 3; r=

With recent changes to dependencies, 'mach test-info' can now run under python 3.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be7a56eeccc3
Run 'mach test-info' with python 3; r=jmaher

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/be7a56eeccc3