1639033 - Fix various compile warnings in NSS

Status: RESOLVED FIXED

(NSS :: Libraries, task)

Description

[Jeff Walden [:Waldo]]

I got annoyed at some of the warning-spam at end of Firefox builds and decided to do some upstream fixing. Didn't get to anywhere close to all the warnings that are currently present, but I knocked out all the warnings in eight or nine different files, at least. (I looked at warnings in several other files as well, but Searchfox led me to callers where I couldn't readily tell changing types, or similar, wouldn't change behavior if done too eagerly.)

Patches forthcoming, will comment on each after posting with the particular warning I've killed off in them.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Bug 1639033 - Fix signed-unsigned comparison warning in basicutil.c. r=kjacobs!

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Bug 1639033 - Make all |moduleIndex| variables in pkcs11.c be unsigned, to eliminate a -Wsign-compare warning. r=kjacobs!

Depends on D75840

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Bug 1639033 - Use the jarType enum type, not int, for certain variables and arguments in jar.c -- for greater precision, and to avoid sign-comparison warnings. r=kjacobs!

Depends on D75841

Comment 4

[Jeff Walden [:Waldo]]

Attachment: Bug 1639033 - Change +sftk_xcbc_mac_pad's block-size argument to be unsigned int to avoid sign-comparison warnings. r=kjacobs!

Depends on D75842

Comment 5

[Jeff Walden [:Waldo]]

Attachment: Bug 1639033 - Use size_t for loops up to sizeof(T) in aeskeywrap.c to eliminate some signed-comparison warnings. r=kjacobs!

Depends on D75843

Comment 6

[Jeff Walden [:Waldo]]

Attachment: Bug 1639033 - Use unsigned int for various count variables in mplogic.c to eliminate signed-unsigned comparison warnings. r=kjacobs!

Depends on D75844

Comment 7

[Jeff Walden [:Waldo]]

Attachment: Bug 1639033 - Use unsigned int rather than int for two variables to eliminate a bunch of signed-unsigned comparison warnings. r=kjacobs!

Depends on D75845

Comment 8

[Jeff Walden [:Waldo]]

Attachment: Bug 1639033 - Used unsigned int instead of int in a few places in ec.c to eliminate signed-unsigned comparison warnings. r=kjacobs!

Depends on D75846

Comment 9

[Jeff Walden [:Waldo]]

Attachment: Bug 1639033 - Use unsigned int for a loop counter to eliminate a signed-unsigned comparison warning in aes-x86.c. r=kjacobs!

Depends on D75847

Comment 10

[Kevin Jacobs [:kjacobs]]

https://hg.mozilla.org/projects/nss/pushloghtml?changeset=e23fe363fa058e9b289ae03cd352fc1f9e057146

Thanks for the fixes!