1639148 - Disable telemetry on weekly Fennec tests

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Florin Strugariu [:Bebe]]

Weekly Fennec tests have been identified of running with telemetry enabled.

Disable telemetry and make sure we don't submit this data when running automated tests

Comment 1

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Could someone point me to the log or code that shows the telemetry is enabled on fennec tests?

Comment 2

[Florin Strugariu [:Bebe]]

I think there is a pref in firefox.
I think it's something related with: toolkit.telemetry.enabled

Henrik can you confirm it this is true?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I don't know, sorry.

Comment 4

[Alexandru Ionescu (needinfo me) [:alexandrui]]

My question is how exactly Fennec tests been identified of running with telemetry enabled? There's a way of disabling telemetry connection and another way of preventing the telemetry data to be uploaded.

Comment 5

[Florin Strugariu [:Bebe]]

run a test in debug mode and open about:config. There you can search for the perf in question and see if it's enabled or disabled

Comment 6

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Attachment: Bug 1639148 Disable telemetry on weekly Fennec tests r?#perftest,dexter,RyanVM

Comment 7

[Alexandru Ionescu (needinfo me) [:alexandrui]]

:chutten, shouldn't I set datareporting.healthreport.uploadEnabled to false instead for this patch?

Comment 8

[Chris H-C :chutten]

Ah, with this question you unfortunately start a History Lesson : )

Back around Firefox 42 we had two data reporting mechanisms: Telemetry and Firefox Health Report. A project, called "Telemetry Unification", combined the two so that no one had to worry about which system was which.... Except that Fennec was outside of the scope of the project and so remains without "Unified Telemetry" to this day.

This means Fennec uses the old pref for turning telemetry upload on and off (toolkit.telemetry.enabled) instead of the unified one (datareporting.healthreport.uploadEnabled). You can see some of this complexity in TelemetryControllerBase and the Telemetry Preferences Documentation.

Hope that helps!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94eaec214310
Disable telemetry on weekly Fennec tests r=chutten,Dexter

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/94eaec214310