1639165 - Errors from content page are logged twice in the Multiprocess Browser Toolbox

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Go to https://nchevobbe.github.io/demo/console-test-app.html
2. Open the multiprocess browser toolbox
3. In the content page, click on the "Exception" button

Expected results

An error is displayed in the browser toolbox

Actual results

2 errors are displayed in the browser toolbox.

---

After some investigation, I was able to see that those messages are coming from different targets.
The first one is from the content process target, and the second one from the parent process one.

I think the second message is coming from xpcom/base/nsConsoleService.cpp#162, where nsIScriptError from the content processes are forwarded to the parent process.

We should return early in MaybeForwardScriptError if devtools.browsertoolbox.fission is set to true.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1639165 - Add an isFowardedFromContentProcess flag to nsIScriptError. r=baku.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

What's said in comment 0 isn't relevant. The duplication happens because we also log from dom/ipc/ContentChild.cpp#455-538.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14084268455c
Don't log message from ContentChild when multiprocess browser toolbox is enabled. r=baku.

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for multiple console related failures.

backout: https://hg.mozilla.org/integration/autoland/rev/46029e7b4eadb143ba7276929aec053451c2cfc4

push:

• https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=bc1&revision=14084268455c5d048b9113a0d21bdd8c1853c6ee
• https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=xpcshell&revision=14084268455c5d048b9113a0d21bdd8c1853c6ee

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

ah, this wasn't caught by my TRY push, I'll investigate

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1639165 - Don't log messages forwarded from content processes when multiprocess browser toolbox is enabled. r=Honza.

We were getting duplicated nsIScriptError in the Browser Toolbox console and the Browser Console
when the multiprocess pref is enabled, because error from content processes are forwarded to
the main process.
The previous patch of this queue added a isForwardedFromContentProcess flag to nsIScriptError,
that we use in this patch to not handle forwarded messages in multiprocess browser console
and browser toolbox console.

Depends on D76792

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5cd10328f91
Add an isFowardedFromContentProcess flag to nsIScriptError. r=baku.
https://hg.mozilla.org/integration/autoland/rev/6c7cd0394f8d
Don't log messages forwarded from content processes when multiprocess browser toolbox is enabled. r=Honza.

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failures on browser_webconsole_stubs_css_message.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/c835da226e6d4fe1da1343990df41d024b59d3ae
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305194233&repo=autoland&lineNumber=11077

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd256d1ad341
Add an isFowardedFromContentProcess flag to nsIScriptError. r=baku.
https://hg.mozilla.org/integration/autoland/rev/ad832014f2d2
Don't log messages forwarded from content processes when multiprocess browser toolbox is enabled. r=Honza.

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

fixed the failing tests

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fd256d1ad341
https://hg.mozilla.org/mozilla-central/rev/ad832014f2d2