1639230 - Remove Mozilla extension for Print to PDF

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://w3c.github.io/webdriver/#print is officially supported now. As such the command needs to be moved out of the Mozilla vendor extensions to the general list of commands, and the webdriver tests have to be moved under /testing/web-platform-tests/tests/webdriver.

James, would you mind doing that?

Comment 1

[David Burns :automatedtester]

I can take this.

Comment 2

[David Burns :automatedtester]

Attachment: Bug 1639230: Remove vendor prefix for printing with webdriver

This removes the vendor prefix for printing to PDF as it has landed in
the WebDriver specification[1]. It moves the wpt to the main test suite.

[1] https://w3c.github.io/webdriver/#print

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c55864fc7a4a
Remove vendor prefix for printing with webdriver r=jgraham,webdriver-reviewers

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23746 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c55864fc7a4a

Comment 7

[Chris Peterson [:cpeterson]]

David, I get the following rust compilation warning-as-error after updating to the latest mozilla-central. I think it's a regression from this bug. I don't know why it didn't break the build on Treeherder. I'm using rustc version 1.43.1 (8d69840ab 2020-05-04).

 error: unused variable: `x`
     --> testing/geckodriver/src/marionette.rs:1046:19
      |
 1046 |         Print(ref x) => Some(Command::WebDriver(MarionetteWebDriverCommand::Print)),
      |                   ^ help: consider prefixing with an underscore: `_x`

Comment 8

[Sylvestre Ledru [:Sylvestre]]

I morphed the issue into a new bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1640483

Comment 9

[David Burns :automatedtester]

I am using the version of Rust that bootstrap says is new enough. Perhaps the Mozilla team looking after this code can get it fixed.

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot