1639252 - Use PRAGMA analysis_limit=N before PRAGMA optimize

Status: RESOLVED INVALID

(Toolkit :: Places, task, P3)

Description

[Marco Bonardo [:mak]]

This is just an optimization to do less work. We can use the suggested N=1000 value.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1639252 - Limit SQLite analysis workload with PRAGMA analysis_limit - r?mak!

Comment 2

[James Teow [:jteow]]

I posted a patch but I think we don't need to do this anymore:

Beginning with SQLite version 3.46.0 (2024-05-23), the recommended way of running ANALYZE is with the PRAGMA optimize command. The PRAGMA optimize will automatically set a reasonable, temporary analysis limit that ensures that the PRAGMA optimize command will finish quickly even on enormous databases. Applications that use the PRAGMA optimize instead of running ANALYZE directly do not need to set an analysis limit.

Comment 3

[James Teow [:jteow]]

I verified with Marco that we're well beyond 3.46. As a result, we don't need to do this.