1639284 - Store records, timestamp and metadata in one IndexedDB transaction

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, enhancement, P3)

Description

[Mathieu Leplatre [:leplatrem]]

It will be more efficient, will prevent race conditions on the client (eg. .get({ verifySignature: true }) while syncing...

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1639284 - Store records, timestamp and metadata in one IndexedDB transaction r?Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da7cbff78183
Store records, timestamp and metadata in one IndexedDB transaction  r=Gijs,extension-reviewers,mixedpuppy

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset da7cbff78183 for causing failures in test_engine_selector_remote_settings.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/745b6a014f52ee3b860ca5eaf9da96f9c16fd797

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=745b6a014f52ee3b860ca5eaf9da96f9c16fd797&fromchange=50a3843bd942d7106257064cf158ffea65192ea0&selectedTaskRun=CAhJ1xZcTnyceLR1Xva4iw.0

Failure logs

• xpcshell: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306666532&repo=autoland&lineNumber=3846
• bc:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306666514&repo=autoland&lineNumber=1905
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306667881&repo=autoland&lineNumber=6639

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e39d1eed06b
Store records, timestamp and metadata in one IndexedDB transaction  r=Gijs,mixedpuppy

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e51ab6678b4
Backed out changeset 7e39d1eed06b for xpcshell failures on test_blocklist_severities.js. CLOSED TREE

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for xpcshell failures on test_blocklist_severities.js.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C7%2Cdebug%2Cxpcshell%2Ctests%2Ctest-windows7-32%2Fdebug-xpcshell-e10s-1%2Cx%28x1%29&fromchange=f26dbc8340cf87ef57bf4b34c0d19541aadd8671&tochange=5e51ab6678b4fe128c6fafa9034a509f80c03d47&selectedTaskRun=dNVY_ad-SZ26YV6LsyZT9g.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=306782492&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/5e51ab6678b4fe128c6fafa9034a509f80c03d47

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0af6d53c082
Store records, timestamp and metadata in one IndexedDB transaction  r=Gijs,mixedpuppy

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for multiple failures e.g. browser_asrouter_whatsnewpanel.js

backout: https://hg.mozilla.org/integration/autoland/rev/ca04319efbdea24b10c2fccd33174339aafede41

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a0af6d53c082d97a83c9c0891c36e35331330880&group_state=expanded

failure logs:

• browser_asrouter_whatsnewpanel.js | Uncaught exception - at resource://services-settings/IDBHelpers.jsm:24 https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307034422&repo=autoland&lineNumber=8971
• browser_RecipeRunner.js | Filter should not be evaluated - https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307034412&repo=autoland&lineNumber=25906
• browser_blocking.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/plugins/head.js:300 https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307034404&repo=autoland&lineNumber=5274
• and more

Comment 9

[Mathieu Leplatre [:leplatrem]]

Sorry about the overhead Natalia...

This is becoming annoying. Tests were passing here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=502352dddef75210043a79133ef849c01d21bee8

I'll see what I can reproduce locally.

Comment 10

[Mathieu Leplatre [:leplatrem]]

Does this look good?
At the least the previously failing seem to have disappeared!
https://treeherder.mozilla.org/#/jobs?repo=try&revision=92f0bcd0ae0c0f1c908d3b1aff4b448b2f8e9139
Thanks 🙏

Comment 11

[Cosmin Sabou [:CosminS]]

Mathieu, unfortunately not. There still are a couple of test failures on that try push.
Logs:
dom/media/tests/mochitest/test_peerConnection_basicH264Video.html - https://treeherder.mozilla.org/logviewer.html#?job_id=307067960&repo=try
gtest/dependentlibs.list.gtest - https://treeherder.mozilla.org/logviewer.html#?job_id=307067603&repo=try
these cppunit - https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307067750&repo=try&lineNumber=1537
Push with jobs classified.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3022366753c9
Store records, timestamp and metadata in one IndexedDB transaction  r=Gijs,mixedpuppy

Comment 13

[Mathieu Leplatre [:leplatrem]]

None of the failing tests are related to my changes. I rebased and re-run a try with all tests and again, the failing tests are completely unrelated or intermittent. https://treeherder.mozilla.org/pushhealth.html?repo=try&revision=661eb8c834c46455c9cf103c035c59e053abcad2

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3022366753c9