163929 - Provide mozilla configuration header for embeddors

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[hacker formerly known as [e-mail]]

It seems as though some embeddors and other users of the mozilla codebase are
being blindsided by changes that require specific defines to be set (eg, bug
155852).  The mozilla-config script provides the list of defines for a
particular mozilla configuration but has the side-effect of being unix-centric
and signficantly increasing the length of the build commandline.  

As an alternative, I'm proposing to provide a mozilla-config.h header as well
which would contain the same defines as the mozilla-config script.  The easiest
thing to do would be to rename config-defs.h to mozilla-config.h and to make it
always be generated by configure.

If we are going to state that embeddors should use this file, then it should
contain all of the important defines needed to build against the mozilla
headers.  That means moving any defines used by public headers into configure so
that mozilla-config.h is generated in a useful manner.

Comment 1

[hacker formerly known as [e-mail]]

Attachment: config-defs.h -> mozilla-config.h

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 96246 [details] [diff] [review]
config-defs.h -> mozilla-config.h

r=bryner

Comment 3

[hacker formerly known as [e-mail]]

Patch has been checked in.