1639334 - Restrict gv-junit-e10s-multi to integration and m-c

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, task, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Sheriffs are concerned when there are failures on beta. Let's restrict this test suite to mozilla-central until e10s-multi is ready to ride the trains.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Oh, and integration trees.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1639334: Restrict gv-junit-e10s-multi test suite to trunk and try; r=gbrown

I think I did this right?

Until we ride the trains, we only want to run this suite for integration
branches, mozilla-central, and try pushes.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 9150254 [details]
Bug 1639334: Restrict gv-junit-e10s-multi test suite to trunk and try; r=gbrown

Beta/Release Uplift Approval Request

• User impact if declined: No user impact, this is to remove a test suite that is not currently needed on beta and release.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change to taskgraph configuration involving test suite that is not currently riding the trains.
• String changes made/needed:

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5afe8992fb3e
Restrict gv-junit-e10s-multi test suite to trunk and try; r=gbrown

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5afe8992fb3e

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9150254 [details]
Bug 1639334: Restrict gv-junit-e10s-multi test suite to trunk and try; r=gbrown

thanks.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2b18bbf2bf80

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1639334 - Restrict gv-junit-e10s-multi to trunk. r=tomprince

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Still running on beta: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&selectedTaskRun=YcuRWAoxSyKqkuJsLN4B7A-0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=bb2ce87358c110671f4832a82c619a2fbf9138f3

Comment 10

[(No longer employed by Mozilla) Aaron Klotz]

Tom, I see your comment -- do you know what's going on here? Can we resolve this bug and file a follow-up, or is there still something that needs to be landed here?

Comment 11

[Tom Prince [:tomprince]]

Attachment: Bug 1639334: Set `run-on-projects` for `gv-junit-e10s-multi` correctly; r?ahal

The original patch add run-on-projects to TEST_VARIANTS, but nothing
currently looks at that. Move it into a replace block, which gets merged with
the task definition.

This is enough to handle this specific change, but if more control is needed
per-test, we should revisit how this is handled. Fission supports
fission-run-on-projects and fission-tier to override those values based on
the variants, but it would probably make sense to generalize those to have more
general way of specifying variant-specific configuration.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80a88565fb9b
Set `run-on-projects` for `gv-junit-e10s-multi` correctly; r=ahal

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/80a88565fb9b

Comment 14

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 9151617 [details]
Bug 1639334: Set run-on-projects for gv-junit-e10s-multi correctly; r?ahal

Beta/Release Uplift Approval Request

• User impact if declined: Test suites running in beta for a non-shipped configuration.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch, taskgraph fix.
• String changes made/needed:

Comment 15

[Julien Cristau [:jcristau]]

Comment on attachment 9151617 [details]
Bug 1639334: Set run-on-projects for gv-junit-e10s-multi correctly; r?ahal

78 merged to beta today and already has this

Comment 16

[[e-mail] (:bhearsum)]

Attachment: Bug 1649334: disable gv-junit-e10s-multi for android opt builds on autoland

Comment 17

[Chris Peterson [:cpeterson]]

Moving some e10s bugs to the new GeckoView::Sandboxing component.