1639435 - Crash in [@ java.lang.IllegalStateException: at org.mozilla.gecko.process.GeckoProcessManager$ChildConnection.getPid(GeckoProcessManager.java)]

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This bug is for crash report bp-63201adb-ec41-414f-ab1b-a493f0200520.

Java stack trace:

java.lang.IllegalStateException
	at org.mozilla.gecko.process.GeckoProcessManager$ChildConnection.getPid(GeckoProcessManager.java:4)
	at org.mozilla.gecko.process.GeckoProcessManager$ChildConnection.bind(GeckoProcessManager.java:12)
	at org.mozilla.gecko.process.GeckoProcessManager.start(GeckoProcessManager.java:7)
	at org.mozilla.gecko.process.GeckoProcessManager.lambda$start$4(GeckoProcessManager.java:2)
	at org.mozilla.gecko.process.-$$Lambda$GeckoProcessManager$f3c4adslVLFeRpGUG7Noos477nk.run(Unknown Source:20)
	at org.mozilla.gecko.util.XPCOMEventTarget.runOnLauncherThread(XPCOMEventTarget.java:3)
	at org.mozilla.gecko.process.GeckoProcessManager.start(GeckoProcessManager.java:4)

We need to get rid of GeckoProcessManager.buildLogMsg

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1639435: Remove GeckoProcessManager.buildLogMsg and change its callsite to just use a literal string; r=#geckoview-reviewers

GeckoProcessManager.buildLogMsg requires a successful bind to construct its
message, but its only remaining callsite is only invoked when a bind fails,
so it blows up.

This patch eliminates buildLogMsg and just changes the callsite to use
a string literal.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/399e60cb2d0b
Remove GeckoProcessManager.buildLogMsg and change its callsite to just use a literal string; r=geckoview-reviewers,droeh

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 9150348 [details]
Bug 1639435: Remove GeckoProcessManager.buildLogMsg and change its callsite to just use a literal string; r=#geckoview-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Crashes
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial, well-understood fix
• String changes made/needed:

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/399e60cb2d0b

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9150348 [details]
Bug 1639435: Remove GeckoProcessManager.buildLogMsg and change its callsite to just use a literal string; r=#geckoview-reviewers

Geckoview crash fix, patch looks safe, approved for 77 beta, thanks.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9104b1bada33