Closed Bug 1639468 Opened 5 years ago Closed 5 years ago

Incorrect documentation of authentication algorithms in telemetry

Categories

(NSS :: Libraries, defect, P1)

Tracking

(firefox78 fixed)

RESOLVED FIXED
Tracking Status
firefox78 --- fixed

People

(Reporter: beurdouche, Assigned: beurdouche)

Details

Attachments

(1 file)

The documentation of the SSL_AUTH_ALGORITHM_FULL probe is incorrect.
https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/Histograms.json#11254

Searching in the code I found:
https://searchfox.org/mozilla-central/source/security/manager/ssl/nsNSSCallbacks.cpp#1320

The bucket values refer to:
https://searchfox.org/mozilla-central/source/security/nss/lib/ssl/sslt.h#172

1 -> RSA signature in the case of RSA key exchange
4 -> ECDSA
7 -> RSA PKCS1.5

Should probably be filled under Toolkit::Telemetry ?

Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17f989b21003 Incorrect documentation of TLS authentication algorithms in telemetry. r=mt
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: