1639509 - Remove "mach uuid"

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task, P4)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1639483 +++

According to https://sql.telemetry.mozilla.org/queries/71268/source?p_date=d_this_month
mach search are super rarely used (6 usages this month) and we don't need "uuid" anymore for the Firefox development.

We have too many mach target, we should trim the list a bit

https://searchfox.org/mozilla-central/source/tools/mach_commands.py#99-116

Tutorial:
https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html

Comment 1

[ekanshbhatnagar]

I want to contribute. How can I start fixing this bug?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

You should follow the tutorial here:
https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html
Good luck :)

Comment 3

[Nilabja Bhattacharya]

Hi, should I just remove the class or something else is expected?

@CommandProvider
class UUIDProvider(object):
    @Command('uuid', category='misc',
             description='Generate a uuid.')
    @CommandArgument('--format', '-f', choices=['idl', 'cpp', 'c++'],
                     help='Output format for the generated uuid.')
    def uuid(self, format=None):
        import uuid
        u = uuid.uuid4()
        if format in [None, 'idl']:
            print(u)
            if format is None:
                print('')
        if format in [None, 'cpp', 'c++']:
            u = u.hex
            print('{ 0x%s, 0x%s, 0x%s, \\' % (u[0:8], u[8:12], u[12:16]))
            pairs = tuple(map(lambda n: u[n:n+2], range(16, 32, 2)))
            print(('  { ' + '0x%s, ' * 7 + '0x%s } }') % pairs)

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Should be enough!

Comment 5

[Nilabja Bhattacharya]

Attachment: Bug 1639509 Remove mach uuid

Comment 6

[Nilabja Bhattacharya]

Attachment: Bug 1639509 Remove mach uuid

Comment 7

[Nilabja Bhattacharya]

Hi, I have submitted the changes

Comment 8

[Nilabja Bhattacharya]

Hi, please review the submission.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Please set a reviewer. See:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-write-a-patch

Next time, please amend the existing review instead of creating a new one (documented on the same page)

Comment 10

[Nilabja Bhattacharya]

Attachment: Bug 1639509 Remove mach uuid

Comment 11

[Nilabja Bhattacharya]

I tried submitting to the same revision but I was unable to, on using 'moz-phab submit' it created a new revision, 'hg histedit' had only 1 pick

Comment 12

[Nilabja Bhattacharya]

Attachment: Bug 1639509 Remove mach uuid

Comment 13

[Justin Wood (:Callek)]

(In reply to Nilabja Bhattacharya from comment #11)

I tried submitting to the same revision but I was unable to, on using 'moz-phab submit' it created a new revision, 'hg histedit' had only 1 pick

Sometimes this can happen if you do hg commit -m "..." --amend if you leave out the -m "...." part it should pop up an editor for the commit message. In said editor just leave the url to our phabricator instance intact and things should just work.

Comment 14

[Nilabja Bhattacharya]

(In reply to Justin Wood (:Callek) from comment #13)

(In reply to Nilabja Bhattacharya from comment #11)

I tried submitting to the same revision but I was unable to, on using 'moz-phab submit' it created a new revision, 'hg histedit' had only 1 pick

Sometimes this can happen if you do hg commit -m "..." --amend if you leave out the -m "...." part it should pop up an editor for the commit message. In said editor just leave the url to our phabricator instance intact and things should just work.

Thank you for the comment, I will do this the next time. Should I make changes to the current revision or is it fine?

Comment 15

[Nilabja Bhattacharya]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #9)

Please set a reviewer. See:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-write-a-patch

Next time, please amend the existing review instead of creating a new one (documented on the same page)

Hi, please look into the fix D79540.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5295aa971bf7
Remove mach uuid r=championshuttler,rstewart

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5295aa971bf7

Comment 19

[Sylvestre Ledru [:Sylvestre]]

On a Debian/Ubuntu: this can be done with https://packages.debian.org/bullseye/uuid on
$ uuid -m
c993d6fa-91ed-11eb-9ae4-c33cdeab2ba3