1639548 - Purge private browsing mode storage on private browsing mode session end

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P3)

Description

[Simon Giesecke [:sg] [he/him]]

Note from asuth:

A purge needs to be added for shutdown and the private browsing last window closed for the OriginAttribute variant.

Comment 1

[Simon Giesecke [:sg] [he/him]]

This probably can be done by registering observers like this: https://searchfox.org/mozilla-central/rev/ea7f70dac1c5fd18400f6d2a92679777d4b21492/dom/localstorage/ActorsParent.cpp#9488-9509

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1639548 - Purge private browsing mode storage on private browsing mode session end. r=#dom-workers-and-storage

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1639548 - Remove redundant purging of localstorage private mode data. r=#dom-workers-and-storage,janv

Depends on D86562

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 5

[Harveer Singh]

Attachment: WIP: Bug 1639548 - Purge private browsing mode storage on private browsing mode session end. r=#dom-workers-and-storage

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1639548 - Move IndexedDBCipherKeyManager to DatabaseFileManager; r=#dom-storage

Depends on D86704

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d75a6ebb97d3
Purge private browsing mode storage on private browsing mode session end. r=dom-workers-and-storage-reviewers,janv DONTBUILD

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3251a6ea2ed
Remove redundant purging of localstorage private mode data. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/2da5597a6ab0
Move IndexedDBCipherKeyManager to DatabaseFileManager; r=hsingh

Comment 9

[Marian-Vasile Laza]

Backed out 5 changesets (Bug 1639545, Bug 1639548, Bug 1818214) for multiple mochitest dom/indexedDB/test/... related test failures.
Backout link
Push with failures <--> 2
Failure Log
Fixed by commit filter

Comment 10

[Marian-Vasile Laza]

Backed out changeset d75a6ebb97d3 (Bug 1639548) for high freq marionette failures on test_IDB_encryption_PBM.py.
Backout link
Push with failures <--> Mn
Failure Log

This also fixes the reappearance of the Bb bustage after the fix was also backed out.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0472cc860cab
Purge private browsing mode storage on private browsing mode session end. r=janv
https://hg.mozilla.org/integration/autoland/rev/00764be394ec
Remove redundant purging of localstorage private mode data. r=janv
https://hg.mozilla.org/integration/autoland/rev/f13ecef45c88
Move IndexedDBCipherKeyManager to DatabaseFileManager; r=hsingh

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/0472cc860cab
https://hg.mozilla.org/mozilla-central/rev/00764be394ec
https://hg.mozilla.org/mozilla-central/rev/f13ecef45c88

Comment 13

[Jan Varga [:janv]]

The backout and relanding addressed by Harveer IIRC.