1639612 - Factor *Scope::Data structures into GC, Non-GC, and NamesList components.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Kannan Vijayan [:djvj]]

This is a blocker for atoms translation work. All the current Scope::Data structures are used both by VM-lifetime Scope structures (e.g. LiteralScope, VarScope, etc.) as well as by parser-internal code (within FunctionBox, for example).

The parser-internal code needs to reference the parser representation of atoms, while
the overall structure should be one that's easily translateable to the corresponding in-vm Scope::Data type.

The plan here is to abstract the implementation of TrailingNamesArray, as well as pull the non-gc fields of the various Scope::Data structures into their own corresponding Fields structs.

This lets the parser later implement its own surrogates for the ::Data structures that use parser-internal name representations.

Comment 1

[Kannan Vijayan [:djvj]]

Attachment: Bug 1639612 - Reorganize Scope::Data structures to factor out non-GC state used by the parser. r?tcampbell

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f1873b1c400
Reorganize Scope::Data structures to factor out non-GC state used by the parser. r=tcampbell

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1f1873b1c400