1639616 - [Protections Dashboard 1.5] Monitor card cache has stopped working

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Erica Wright [:ewright]]

The Monitor card now fully updates with each refresh, we should look into why this changed, and either fix the cache or remove related code.

Comment 1

[Erica Wright [:ewright]]

Neil, We've lost our ability to cache because in browser/actors/AboutProtectionsParent.jsm the AboutProtectionsParent is rerunning the constructor on each page refresh. Is this part of the JSWindowActor design?

Comment 2

[Neil Deakin]

Yes, so it looks like monitorResponse should just be a global instead of a member. Is there an easy way to test the issue being caused here? Or write an automated test?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1614743

Comment 4

[Erica Wright [:ewright]]

(In reply to Neil Deakin from comment #2)

Yes, so it looks like monitorResponse should just be a global instead of a member. Is there an easy way to test the issue being caused here? Or write an automated test?

To test manually:
go to about:protections
log into your Firefox account, and sign up for monitor
refresh the page - you should see your monitor data.
open browser dev tools and set a debugger on browser/actors/AboutProtectionsParent.jsm line 78 (if (this.monitorResponse && this.monitorResponse.timestamp) {)
refresh the page again, and this.monitorResponse should be an object, but instead it is null

We can write an automated test for this fairly easily - should have done it before. I can do that.

Comment 5

[Pascal Chevrel (relman team) -> :pascalc]

Wontfix for 77 as we shipped our last beta and this is a S3.

Comment 6

[Erica Wright [:ewright]]

Attachment: Bug 1639616 - Turn Monitor cache back on.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7363797d74f
Turn Monitor cache back on. r=prathiksha

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c7363797d74f