1639618 - toolchain-linux64-clang-7 fails to build

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Rob Lemley [:rjl]]

https://firefox-ci-tc.services.mozilla.com/tasks/Xt3gi7fgSYuMbFH-y_nSgg

[task 2020-05-20T11:41:07.669Z] python3 $GECKO_PATH/build/build-clang/build-clang.py -c $GECKO_PATH/$1
[task 2020-05-20T11:41:07.759Z] patch -d /builds/worker/fetches/llvm-project -p1 -i /builds/worker/workspace/build/src/build/build-clang/static-llvm-symbolizer.patch --fuzz=0 -s
[task 2020-05-20T11:41:07.762Z] patch -d /builds/worker/fetches/llvm-project -p1 -i /builds/worker/workspace/build/src/build/build-clang/find_symbolizer_linux-clang-9.patch --fuzz=0 -s
[task 2020-05-20T11:41:07.764Z] patch: **** Can't open patch file /builds/worker/workspace/build/src/build/build-clang/find_symbolizer_linux-clang-9.patch : No such file or directory

It looks like the file got renamed with the switch to clang-10, and the right patch is now find_symbolizer_linux.patch.

linux64-mar-tools is using clang-7, at the moment Thunderbird Nightly for 2020-05-20 is stuck because it wants to rebuild clang-7 and cannot.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1639618 - Use correct find_symbolizer_linux patch when building clang-7. r?#firefox-build-system-reviewers

The "clang-9" variant of the patch is no longer present. For clang-7, the patch
file to use is now "find_symbolizer_linux.patch".

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd8f013eed8b
Use correct find_symbolizer_linux patch when building clang-7. r=froydnj

Comment 3

[Mike Hommey [:glandium]]

There's only one job using clang 7, and there are no reasons for it to use clang 7. It should be updated to use the current clang (or the baseline clang, whichever), and clang 7 removed.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fd8f013eed8b