1639624 - mach bootstrap should work without setuptools

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

I just used ./mach bootstrap on a fresh Ubuntu and got

ModuleNotFoundError: No module named 'distutils.sysconfig'

That's no way to welcome new contributors :)

Comment 1

[Nathan Froyd [:froydnj]]

(In reply to David Teller [:Yoric] (please use "needinfo") from comment #0)

I just used ./mach bootstrap on a fresh Ubuntu and got

ModuleNotFoundError: No module named 'distutils.sysconfig'

That's no way to welcome new contributors :)

That was the only error output? If it wasn't, can you please provide the complete message?

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: VirtualBox_Ubuntu 20.04_20_05_2020_19_52_09.png

Sorry, can't copy and paste from my VM, but here's the stack.

Comment 3

[Ricky Stewart]

Attachment: Bug 1639624 - Don't import from `distutils` unless absolutely necessary in virtualenv.py

Similar reasoning to bug 1638780.

Comment 4

[Ricky Stewart]

This is similar to, but actually not a dupe of, bug 1638780.

Thanks for the report; can you confirm the patch fixes the problem, or does it throw another error after that?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4376d47f325b
Don't unconditionally import `VirtualenvManager` in `python/mach_commands.py`. r=froydnj

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for bustage.

backout: https://hg.mozilla.org/integration/autoland/rev/e1d2e169db4ee4b25ecef6862411736e671cf76d

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=4376d47f325bd95a3e09e16bcb194a13f5e2e98c&searchStr=build&selectedTaskRun=CDTnbWCjSrOX49Vsi1c_aw-0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303176026&repo=autoland&lineNumber=59299

[task 2020-05-21T00:20:45.615Z] 00:20:45 INFO - check>
[task 2020-05-21T00:20:45.615Z] 00:20:45 INFO - check> Exception: Failed to create virtualenv: z:/build/workspace/obj-build_virtualenvs\init_py3 (virtualenv.py retcode: 1)
[task 2020-05-21T00:20:45.615Z] 00:20:45 INFO - check>
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> File "z:/build/build/src\python/mach_commands.py", line 127, in python_test
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> return self.run_python_tests(*args, **kwargs)
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> File "z:/build/build/src\python/mach_commands.py", line 142, in run_python_tests
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> self._activate_test_virtualenvs(python)
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> File "z:/build/build/src\python/mach_commands.py", line 265, in _activate_test_virtualenvs
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> py3_manager.ensure(python3)
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> File "z:/build/build/src\python/mozbuild\mozbuild\virtualenv.py", line 194, in ensure
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> return self.build(python)
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> File "z:/build/build/src\python/mozbuild\mozbuild\virtualenv.py", line 492, in build
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> self.create(python)
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> File "z:/build/build/src\python/mozbuild\mozbuild\virtualenv.py", line 259, in create
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> self.virtualenv_root, result))
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> z:/build/build/src/testing/testsuite-targets.mk:271: recipe for target 'check' failed
[task 2020-05-21T00:20:45.616Z] 00:20:45 INFO - check> mozmake.EXE[2]: *** [check] Error 1

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01a6713f1aeb
Don't import from `distutils` unless absolutely necessary in virtualenv.py r=froydnj

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/01a6713f1aeb