1639627 - [css-sizing] Make flex % row-gap resolve to 0 when height is indefinite (only flex, not grid)

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, defect)

Description

A resolution was made for csswg-drafts/#5081.

[css-sizing] Make flex % row-gap resolve to 0 when height is indefinite (only flex, not grid)

• RESOLVED: % based gaps for flex in the case of resolving against an indefinite constraint resolve to 0

Discussion.

Comment 1

[Daniel Holbert [:dholbert]]

This basically means we should directly revert bug 1473047 (which is where we implemented the spec behavior that's being removed/simplified here).

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1639627: [css-flex] Make flex-container percent 'row-gap' values resolve to 0, when they're resolved against an indefinite block-size. r?TYLin

This implements a CSSWG resolution in this issue:
https://github.com/w3c/csswg-drafts/issues/5081

This also effectively backs out our changes from
https://bugzilla.mozilla.org/show_bug.cgi?id=1473047
which is where we implemented our current behavior.

I'm fixing the reftest that we have on this behavior to expect that all of its
gaps (which are all in the affected category) resolve to 0; and I'm adjusting
our expectations for its WPT reimport to expect failure until the test changes
have made the roundtrip back into our WPT reimport.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ed4c347cc66
[css-flex] Make flex-container percent 'row-gap' values resolve to 0, when they're resolved against an indefinite block-size. r=TYLin

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5ed4c347cc66

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

WPT import