1639630 - Profiler Java samples limit is not effective while creating the samples array

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Inside the sampling runnable, we are limiting the sampling count but not using that limited value in mSampleCount, using aSampleCount instead which is not limited by anything.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1639630 - Use the limited sample count instead of non-limited one. r?julienw

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1639630 - Increase the java sample count limit to 120000 to cover up to 2 mins with 1ms interval. r?julienw

Depends on D76180

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f785828241b7
Use the limited sample count instead of non-limited one. r=julienw,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/d45e2b2a9491
Increase the java sample count limit to 120000 to cover up to 2 mins with 1ms interval. r=julienw,geckoview-reviewers,agi

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f785828241b7
https://hg.mozilla.org/mozilla-central/rev/d45e2b2a9491