Closed
Bug 1639630
Opened 5 years ago
Closed 5 years ago
Profiler Java samples limit is not effective while creating the samples array
Categories
(Core :: Gecko Profiler, defect, P2)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla78
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: canova, Assigned: canova)
Details
Attachments
(2 files)
Inside the sampling runnable, we are limiting the sampling count but not using that limited value in mSampleCount
, using aSampleCount
instead which is not limited by anything.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D76180
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f785828241b7
Use the limited sample count instead of non-limited one. r=julienw,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/d45e2b2a9491
Increase the java sample count limit to 120000 to cover up to 2 mins with 1ms interval. r=julienw,geckoview-reviewers,agi
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f785828241b7
https://hg.mozilla.org/mozilla-central/rev/d45e2b2a9491
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•