1639718 - Add an OnChannelBlocked UrlClassifier API

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P2)

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1639718 - Add an OnChannelBlocked UrlClassifier API

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku

ChannelClassifierService notifies "urlclassifier-before-block-channel"
event when a channel is going to be blocked by protection features.

It also provides an API for receivers to "unblock" the channel.

Sample usage:
this.service = Cc["@mozilla.org/url-classifier/channel-classifier-service;1"].getService(
Ci.nsIChannelClassifierService
);
if (this.service) {
this.service.addListener({
observe(aSubject, aTopic, aData) {
switch (aTopic) {
case "urlclassifier-before-block-channel":
let channel = aSubject.QueryInterface(Ci.nsIUrlClassifierBlockedChannel);
channel.unblock();
break;
}
},
})
}

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku

Depends on D76836

Comment 4

[Dimi Lee [:dimi]]

Attachment: Bug 1639718 - P3. Add testcase r=baku

Depends on D76837

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35567ab8e0ab
P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku
https://hg.mozilla.org/integration/autoland/rev/10a7cc5f1b44
P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku
https://hg.mozilla.org/integration/autoland/rev/3a5f3040fbef
P3. Add testcase r=baku

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/35567ab8e0ab
https://hg.mozilla.org/mozilla-central/rev/10a7cc5f1b44
https://hg.mozilla.org/mozilla-central/rev/3a5f3040fbef