Closed
Bug 1639727
Opened 5 years ago
Closed 5 years ago
`trackRemainingChanges` is a method on the engine, not the store
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 78
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox76 | --- | unaffected |
| firefox77 | --- | unaffected |
| firefox78 | --- | fixed |
People
(Reporter: lina, Assigned: lina)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Oops! This came up in an error log in bug 1639625—the engine calls trackRemainingChanges on itself after a sync, not on the store! We also need test coverage for this in tabs and prefs.
|
Assignee | |
Comment 1•5 years ago
|
||
This commit fixes two issues: moves trackRemainingChanges to the
engine, since that's where it defined (not on the store), and skips
setting modified if all records have been successfully uploaded.
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/106dc3f2e441
Fix `trackRemainingChanges` in the tabs and prefs Sync engines. r=markh
|
||
Comment 3•5 years ago
|
||
Set release status flags based on info from the regressing bug 1636365
status-firefox76:
--- → unaffected
status-firefox77:
--- → unaffected
status-firefox78:
--- → affected
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
|
|
||
Updated•5 years ago
|
Keywords: regression
|
||
Updated•5 years ago
|
status-firefox-esr68:
--- → unaffected
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•