copy/paste error in disabled button UA rules
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: heycam, Assigned: emilio)
References
Details
Attachments
(6 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
That and the rule below is missing :active in one of the selectors.
|
Reporter | |
Updated•3 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
This will allow us to clean them up.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
I also removed some unneeded specific selectors for ::placeholder /
::-moz-text-control-editing-root / etc. We only query them for textarea
/ input elements, so it is more of a pesimization than an optimization.
Depends on D76262
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D76263
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
There's some lists code that I could technically clean up a bit more, but I
erred in the side of making the selectors as fast as possible with our current
infrastructure.
For example, this selector list:
:is(ul, ol, dir, menu, dl) ul,
:is(ul, ol, dir, menu, dl) ol,
:is(ul, ol, dir, menu, dl) dir,
:is(ul, ol, dir, menu, dl) menu,
:is(ul, ol, dir, menu, dl) dl
Could be reduced to:
:is(ul, ol, dir, menu, dl) :is(ul, ol, dir, menu, dl)
But that means that for dl elements we'll selector-match all the selectors
inside the :is() instead of just dl. Maybe it doesn't matter compared with
the work of going up all the parent chain, but I erred in the side of caution
for most of these.
Depends on D76264
|
|
Assignee | |
Comment 5•3 years ago
|
||
This one I went all-in with :is(). Because even if we have to do some more
selector-matching for each element, we need to check the more expensive
selectors and the combinators less often, so I don't think we end up worse than
before, and the difference is massive.
Depends on D76265
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67dcbffe8b5b Enable :is() and :where() in UA sheets. r=jwatt https://hg.mozilla.org/integration/autoland/rev/c161d7a53845 Clean-up forms.css by using :is(). r=jwatt https://hg.mozilla.org/integration/autoland/rev/b8e3a5d241c9 Cleanup ua.css by using :is(). r=jwatt https://hg.mozilla.org/integration/autoland/rev/ff407bdf357e Cleanup html.css using :is(). r=jwatt https://hg.mozilla.org/integration/autoland/rev/9d8f9a2cd37f Clean up quirks.css using :is(). r=jwatt
|
|
Assignee | |
Comment 7•3 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d0a8420647e Address some nits that I missed.
|
||
Comment 9•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/67dcbffe8b5b
https://hg.mozilla.org/mozilla-central/rev/c161d7a53845
https://hg.mozilla.org/mozilla-central/rev/b8e3a5d241c9
https://hg.mozilla.org/mozilla-central/rev/ff407bdf357e
https://hg.mozilla.org/mozilla-central/rev/9d8f9a2cd37f
https://hg.mozilla.org/mozilla-central/rev/4d0a8420647e
Description
•