Closed Bug 1639901 Opened 5 months ago Closed 5 months ago

[rel=preload] Set `initiatorType` property on nsITimedChannel properly for <link preload> initiated channels

Categories

(Core :: DOM: Networking, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox78 --- fixed
firefox79 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

initiatorType

Example how this is set for images.

All resource types we support preload for should properly set the initiatorType to either "link" or "preload" or "link-preload". Personal pref is "preload".

Whiteboard: [necko-triaged]
Blocks: 1624368

Related is bug 1624368 comment 10 and the following discussion, but my intent to add "preload ${type}" to the initiator is gone after reading the spec.

So, the initiator has to be "link" for all preloads.

This then also no longer blocks bug 1624368.

No longer blocks: 1624368

Comment on attachment 9151070 [details]
Bug 1639901 - Set PerformanceResourceTiming.initiatorType to "link" on channel initiated by <link rel=preload> tags, r=Harald

Beta/Release Uplift Approval Request

  • User impact if declined: minimal, only not properly set property on resourceTiming of preloaded script
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String changes made/needed:
Attachment #9151070 - Flags: approval-mozilla-beta?
Pushed by honzab.moz@firemni.cz:
https://hg.mozilla.org/integration/autoland/rev/7ec8bf497a40
Set `PerformanceResourceTiming.initiatorType` to "link" on channel initiated by `<link rel=preload>` tags, r=hsivonen
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79

It's not clear to me from this bug and comment 4 why we need this in 78. What does this do and why does it matter? (AIUI rel=preload support is not shipping with 78.)

Flags: needinfo?(honzab.moz)

(In reply to Julien Cristau [:jcristau] from comment #7)

It's not clear to me from this bug and comment 4 why we need this in 78. What does this do and why does it matter? (AIUI rel=preload support is not shipping with 78.)

Preload is shipping on 78 (early Beta). This is a detail affecting performance API only when a js script is preloaded (the source is not correctly identified), the patch is simple enough and risk-free to be accepted to Beta.

Flags: needinfo?(honzab.moz)

(In reply to Honza Bambas (:mayhemer) from comment #8)

(In reply to Julien Cristau [:jcristau] from comment #7)

It's not clear to me from this bug and comment 4 why we need this in 78. What does this do and why does it matter? (AIUI rel=preload support is not shipping with 78.)

Preload is shipping on 78 (early Beta). This is a detail affecting performance API only when a js script is preloaded (the source is not correctly identified), the patch is simple enough and risk-free to be accepted to Beta.

"early beta" is not "shipping".

Comment on attachment 9151070 [details]
Bug 1639901 - Set PerformanceResourceTiming.initiatorType to "link" on channel initiated by <link rel=preload> tags, r=Harald

let's take this for 78.0b5 anyway...

Attachment #9151070 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.