1639901 - [rel=preload] Set `initiatorType` property on nsITimedChannel properly for <link preload> initiated channels

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P1)

Description

[Honza Bambas (:mayhemer)]

initiatorType

Example how this is set for images.

All resource types we support preload for should properly set the initiatorType to either "link" or "preload" or "link-preload". Personal pref is "preload".

Comment 1

[Honza Bambas (:mayhemer)]

Related is bug 1624368 comment 10 and the following discussion, but my intent to add "preload ${type}" to the initiator is gone after reading the spec.

So, the initiator has to be "link" for all preloads.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: Bug 1639901 - Set `PerformanceResourceTiming.initiatorType` to "link" on channel initiated by `<link rel=preload>` tags, r=Harald

Comment 3

[Honza Bambas (:mayhemer)]

This then also no longer blocks bug 1624368.

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 9151070 [details]
Bug 1639901 - Set PerformanceResourceTiming.initiatorType to "link" on channel initiated by <link rel=preload> tags, r=Harald

Beta/Release Uplift Approval Request

• User impact if declined: minimal, only not properly set property on resourceTiming of preloaded script
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ec8bf497a40
Set `PerformanceResourceTiming.initiatorType` to "link" on channel initiated by `<link rel=preload>` tags, r=hsivonen

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7ec8bf497a40

Comment 7

[Julien Cristau [:jcristau] (back August 18)]

It's not clear to me from this bug and comment 4 why we need this in 78. What does this do and why does it matter? (AIUI rel=preload support is not shipping with 78.)

Comment 8

[Honza Bambas (:mayhemer)]

(In reply to Julien Cristau [:jcristau] from comment #7)

It's not clear to me from this bug and comment 4 why we need this in 78. What does this do and why does it matter? (AIUI rel=preload support is not shipping with 78.)

Preload is shipping on 78 (early Beta). This is a detail affecting performance API only when a js script is preloaded (the source is not correctly identified), the patch is simple enough and risk-free to be accepted to Beta.

Comment 9

[Julien Cristau [:jcristau] (back August 18)]

(In reply to Honza Bambas (:mayhemer) from comment #8)

(In reply to Julien Cristau [:jcristau] from comment #7)

It's not clear to me from this bug and comment 4 why we need this in 78. What does this do and why does it matter? (AIUI rel=preload support is not shipping with 78.)

Preload is shipping on 78 (early Beta). This is a detail affecting performance API only when a js script is preloaded (the source is not correctly identified), the patch is simple enough and risk-free to be accepted to Beta.

"early beta" is not "shipping".

Comment 10

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9151070 [details]
Bug 1639901 - Set PerformanceResourceTiming.initiatorType to "link" on channel initiated by <link rel=preload> tags, r=Harald

let's take this for 78.0b5 anyway...

Comment 11

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/65797eb50fdf