1639916 - nr_ice_peer_ctx_parse_stream_attributes can leak nr_ice_media_stream in some failure cases

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Byron Campen [:bwc]]

We create here: https://searchfox.org/mozilla-central/rev/df4c90d4b8c92c99f76334acfe4813c573c12661/media/mtransport/third_party/nICEr/src/ice/ice_peer_ctx.c#102

But only pass ownership here:

https://searchfox.org/mozilla-central/rev/df4c90d4b8c92c99f76334acfe4813c573c12661/media/mtransport/third_party/nICEr/src/ice/ice_peer_ctx.c#141

If any failure happens in between, we could leak.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1639916: Clean up pstream if we don't end up using it. r?mjf

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d678808cf0d558e69788a6ff53455eb1c330397

Gtests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5e79c68cb69953ea1710e0daff94cbe12f21b82

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44607deb9604
Clean up pstream if we don't end up using it. r=mjf

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/44607deb9604