1639947 - Large scale in crashtest 1608851.html can cause OOM on mulitple platforms, including Android, Windows, and macOS

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P3)

Description

Filed per mats' suggestion in bug 1584890 Comment 19.

After fixing bug 1584890, layout/generic/crashtests/1608851.html which has a large scale in the style sheet can cause OOM crash on Android.

The test doesn't crash on desktop, but it does yield a warning like [GFX3-]: Surface size too large (exceeds extent limit)!

I'm planning to reland bug 158489 with the test disabled on Android.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

(In reply to Ting-Yu Lin [:TYLin] (UTC-7) from comment #0)

After fixing bug 1584890, layout/generic/crashtests/1608851.html which has a large scale in the style sheet can cause OOM crash on Android.

the test file will be renamed. I am putting a perma link to the old one;
https://searchfox.org/mozilla-central/rev/df4c90d4b8c92c99f76334acfe4813c573c12661/layout/generic/crashtests/1608851.html#8

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Thanks hiro! The old one is going to be renamed to 1608851-1.html in https://phabricator.services.mozilla.com/D76411

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mattwoodrow, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Daniel Holbert [:dholbert]]

It looks like we can re-enable this crashtest now. At least: I did a try push with the test reenabled:
https://treeherder.mozilla.org/jobs?repo=try&revision=4d142a6b8a322ac1b89112e0c49254d6b0ee9564
...and I retriggered Android crashtest runs (8 iterations on opt, 8 iterations on debug), and I never hit any issues.

Given that the original Android issue cropped up on the very first TreeHerder run (based on cset in the "push" link in bug 1584890 comment 17), and now we can reenable and retrigger 8x without hitting a single issue, it looks like the underlying issue has gone away or morphed such that we're OK to have this enabled now.

(Possibly this was addressed by WebRender being enabled, given that we had some warning text that alluded to large graphics layers/surfaces being allocated)

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: Bug 1639947: Re-enable a crashtest that used to crash but seems to be fine now. r?hiro

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13c611e4eaa2
Re-enable a crashtest that used to crash but seems to be fine now. r=hiro

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/13c611e4eaa2