Closed Bug 1639980 Opened 5 years ago Closed 5 years ago

Disabling pocket should disable the "Pages Saved to Pocket" in Firefox Home

Categories

(Firefox :: Enterprise Policies, defect, P5)

Product:
Firefox
Component:
Enterprise Policies
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 79
Tracking Flags:
Tracking Status
firefox-esr78 --- fixed
firefox79 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

Bug 1639980 - Hide Pocket saved pages if Pocket is disabled. r=Mardak
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-esr78+
Details | Review

Pages Saved to Pocket should be disabled if Pocket is disabled.

Also, we should disable sub checkboxes if something is locked and disabled. In particular top sites.

Attachment #9156836 - Attachment description: Bug 1639980 - Showing saved pocket pages should be disabled if pocket is disabled. r?jaws → Bug 1639980 - Hide Pocket saved pages if Pocket is disabled. r=Mardak
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/71b9b0933728 Hide Pocket saved pages if Pocket is disabled. r=Mardak

https://hg.mozilla.org/mozilla-central/rev/71b9b0933728

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

Comment on attachment 9156836 [details]
Bug 1639980 - Hide Pocket saved pages if Pocket is disabled. r=Mardak

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Correctness fix for pocket policy
  • User impact if declined: Pocket pages entry shows in prefs even if pocket is disabled
  • Fix Landed on Version: 79
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Automated test.
  • String or UUID changes made by this patch:
Attachment #9156836 - Flags: approval-mozilla-esr68?

Comment on attachment 9156836 [details]
Bug 1639980 - Hide Pocket saved pages if Pocket is disabled. r=Mardak

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration:
  • User impact if declined:
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String or UUID changes made by this patch:
Attachment #9156836 - Flags: approval-mozilla-esr68? → approval-mozilla-esr78?
QA Whiteboard: [qa-79b-p2]

Comment on attachment 9156836 [details]
Bug 1639980 - Hide Pocket saved pages if Pocket is disabled. r=Mardak

Approved for 78.1esr.

Attachment #9156836 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: