Closed Bug 1640071 Opened 4 years ago Closed 2 years ago

Add a CI build target for ubsan "nonnull-attribute"

Categories

(NSS :: Build, defect, P3)

Product:
NSS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1790763

People

(Reporter: jcj, Unassigned)

References

Details

(Whiteboard: [nss-fx][nss-ci])

We need to get UBSAN running with the new config for m-c sooner than later so that we don't find issues at uplift time.

I don't think we need a new target. We can just add --enable-ubsan to our ASAN builds. That is, unless the time taken is >2 times more than either one alone. We would also need to a nonnull-attribute to the ubsan configuration, which we should probably do already.

It appears that we aren't running ubsan in CI, so fixing this seems fairly important.

Whiteboard: [nss-fx]
Whiteboard: [nss-fx] → [nss-fx][nss-ci]

This has been fixed, we've been running ubsan on our asan builds for a while. See 1790763 for the follow on to enable the full range of checks in Mozilla Central.

Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1790763
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.