1640108 - Minor cleanups in nsPrintJob.cpp

Status: RESOLVED FIXED

(Core :: Printing: Setup, task, P3)

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1640108 - Move SetPrintAsIs in nsPrintObject. r?jwatt

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1640108 - Move nsPrintJob::SetPrintPO into nsPrintObject class and rename it to EnablePrinting. r?jwatt

Depends on D76455

Comment 3

[Hiroyuki Ikezoe (:hiro)]

To be honest, I am quite unsure whether this change will end up an unnecessary work when we finish refactoring printing stuff. :)

Also, for SetPrintAsIs, I noticed there is a suspicious direct mutation of the nsPrintObject::mPrintAsIs. As of now, I can't tell whether it's the right thing to do or it's an underlying issue. (The direct mutation changes the parent's mPrintAsIs but doesn't change siblings' one), so I leave as it is.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5655f21c7c03
Move SetPrintAsIs in nsPrintObject. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/76186c5df6b8
Move nsPrintJob::SetPrintPO into nsPrintObject class and rename it to EnablePrinting. r=jwatt

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5655f21c7c03
https://hg.mozilla.org/mozilla-central/rev/76186c5df6b8