1640117 - Request to access cookie: Incorrect message in console when *Content Blocking* is disabled but *Enhanced Tracking Protection* is enabled

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P3)

Description

[Olivier Vit (just a reporter)]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

Launch a new profile, go to https://www.resoneo.com/
By default, Enhanced Tracking Protection is enabled, NOT Content Blocking

Actual results:

In console I get messages like

Request to access cookie or storage on “<URL>” was blocked because it came from a tracker and content blocking is enabled
Request to access cookie or storage on “https://platform.twitter.com/widgets/widget_iframe.2a0082900…adde2d7b849b06a0bb.html?origin=https%3A%2F%2Fwww.resoneo.com” was blocked because it came from a tracker and content blocking is enabled

Indeed cookies are blocked on that request, but because of Enhanced Tracking Protection being enabled, not because of Content Blocking

This message is inaccurate and misleading to developers willing to understand what is happening and how Firefox Content Blocking may affect their site usability and behavior

Expected results:

It should say

Request to access cookie or storage on “https://platform.twitter.com/widgets/widget_iframe.2a0082900…adde2d7b849b06a0bb.html?origin=https%3A%2F%2Fwww.resoneo.com” was blocked because it came from a tracker and enhanced tracking protection is enabled

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Erica Wright [:ewright]]

I would agree with this. At one point we were calling it "content blocking" but the name has since changed to "enhanced tracking protection", this is likely an artifact from then.

These strings should be changed: https://searchfox.org/mozilla-central/source/netwerk/locales/en-US/necko.properties#40,43,45

Comment 3

[Taegeon Lee]

Attachment: Bug 1640117 Change message in console for blocking contents from content blocking to enhanced tracking protection r=flod

Comment 4

[Taegeon Lee]

Attachment: Bug 1640117 Change message in console for blocking contents from content blocking to enhanced tracking protection.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf9b81801abc
Change message in console for blocking contents from content blocking to enhanced tracking protection. r=nchevobbe,dimi

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failures on browser_webconsole_trackingprotection_errors.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/17d0bbb1f0e017772bec7de7af6329493bdf38e0
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305217365&repo=autoland&lineNumber=4840

Comment 7

[Taegeon Lee]

Should I just add new ids with maintaining previous ids to avoid testfailed?

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ash153311, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[Sonia Singla :soniasingla]

hi, i am working on this bug :) Please assign me !

Comment 10

[Sonia Singla :soniasingla]

Attachment: Bug 1640117 - Change message : Content blocking to enhanced tracking protection. r=ewright

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 13

[Makenzie]

Hello! I'm an Outreachy applicant and I'd love to work on this bug. May I be assigned please?

Comment 14

[gloriaeskor]

I am an outreachy applicant.
Is this still open? I would like to work on it

Comment 15

[gloriaeskor]

I am an outreachy applicant.
Is this still open? I would like to work on it

Comment 16

[Micah [:mtigley] (she/her)]

It looks like there is already a patch that's been approved. Sonia, is there anything else that needs to be done to get this landed?

Comment 17

[Sonia Singla :soniasingla]

It should be ready to land :)

Comment 18

[Ayesha Solanki]

Hi, I'm Ayesha Solanki, an Outreachy applicant. I would like to contribute on this issue. Can you assign it to me?

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 20

[Gautam Panakkal]

I'm working on the rebase now and will be submitting a revision soon.

Comment 21

[Gautam Panakkal]

How should I proceed with taking over the patch? I'm unable to submit changes because I'm not the owner.

Comment 22

[Emma Zühlcke [:emz]]

You can commandeer (= take over) the patch on Phabricator. Scroll to the bottom of the revision and in the "Add action" dropdown select "Commandeer Revision".

Comment 23

[Gautam Panakkal]

(In reply to Emma Zühlcke [:emz] from comment #22)

You can commandeer (= take over) the patch on Phabricator. Scroll to the bottom of the revision and in the "Add action" dropdown select "Commandeer Revision".

I don't have permissions to commandeer - the only options I have there are "Accept Revision" and "Request Changes."

Comment 24

[Emma Zühlcke [:emz]]

I see. Since you're assigned to the bug now, can you just submit a new patch and we abandon the other one?

Comment 25

[Gautam Panakkal]

Sure thing!

Comment 26

[Gautam Panakkal]

Attachment: Bug 1640117 - update console warnings to state 'enhanced tracking protection' instead of 'content blocking' r=emz

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aada20f0f845
update console warnings to state 'enhanced tracking protection' instead of 'content blocking' r=emz,necko-reviewers,devtools-reviewers,flod,anti-tracking-reviewers,nchevobbe

Comment 28

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/aada20f0f845