Closed Bug 1640136 Opened 1 year ago Closed 11 months ago

JSON dump not found when using preview collection

Categories

(Firefox :: Remote Settings Client, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 79
Tracking Status
firefox-esr78 --- fixed
firefox79 --- verified

People

(Reporter: leplatrem, Assigned: leplatrem)

Details

Attachments

(2 files)

We load the JSON dump from .../dumps/{bucketName}/{collectionName}.json.

When pointing the browser at the preview collection, the bucketName becomes main-preview and the dump isn't found. The main consequence is that a full sync is done on .get() with fresh profiles (involving network calls), instead of just loading the packaged dump.

Since the preview collection shares history with the main collection, we could load the dump from ${bucketName.replace("-preview", "")}/${collectionName}.json.

Assignee: nobody → mathieu
Status: NEW → ASSIGNED
Pushed by mleplatre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8a2744a115f
Load main dump when using preview r=Standard8
Pushed by mleplatre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/91da551351b5
Load main dump when using preview r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

== Change summary for alert #26162 (as of Tue, 09 Jun 2020 09:50:12 GMT) ==

Improvements:

3% startup_about_home_paint windows7-32-shippable opt e10s stylo 640.29 -> 618.58
3% startup_about_home_paint windows7-32-shippable opt e10s stylo 632.29 -> 613.92

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26162

Flags: needinfo?(mathieu)

This issue is verified fixed using Firefox 79.0a1 (BuildId:20200619092144) on Windows 10 64bit (Search engines are successfully retrieved from dump first and main-preview after).

Status: RESOLVED → VERIFIED

Comment on attachment 9165052 [details]
Bug 1640136 - Load main dump when using preview r=standard8

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: In order to backport 1649700 to ESR, we need pieces of this 1640136 (and its follow-up 1644153). We thought it would be cleaner and future-proof to uplift the patch rather than just importing pieces.
  • User impact if declined: We would backport 1649700 with a piece of this patch.

For user impact, it means that authors of Remote Settings collections won't be able to preview their changes on top of the default packaged data.

  • Fix Landed on Version: 79
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This patch landed a long time ago, and tests cover the changed part.
  • String or UUID changes made by this patch:
Attachment #9165052 - Flags: approval-mozilla-esr78?
Attachment #9153376 - Flags: approval-mozilla-esr78?
Attachment #9153376 - Flags: approval-mozilla-esr78?

Comment on attachment 9165052 [details]
Bug 1640136 - Load main dump when using preview r=standard8

Approved for 78.1esr.

Attachment #9165052 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
You need to log in before you can comment on or make changes to this bug.