1640136 - JSON dump not found when using preview collection

Status: VERIFIED FIXED

(Firefox :: Remote Settings Client, defect, P3)

Description

[Mathieu Leplatre [:leplatrem]]

We load the JSON dump from .../dumps/{bucketName}/{collectionName}.json.

When pointing the browser at the preview collection, the bucketName becomes main-preview and the dump isn't found. The main consequence is that a full sync is done on .get() with fresh profiles (involving network calls), instead of just loading the packaged dump.

Since the preview collection shares history with the main collection, we could load the dump from ${bucketName.replace("-preview", "")}/${collectionName}.json.

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1640136 - Load main dump when using preview r?standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8a2744a115f
Load main dump when using preview r=Standard8

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset b8a2744a115f (bug 1640136) for XPCShell test/unit/test_remote_settings_worker.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304983429&repo=autoland&lineNumber=2490

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=b8a2744a115f7d4c4ec49c8f82a573db8fdd7dda

Backout:
https://hg.mozilla.org/integration/autoland/rev/b2e08545da6d006cb47690dd2531d0b219f05e42

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91da551351b5
Load main dump when using preview r=Standard8

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/91da551351b5

Comment 6

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #26162 (as of Tue, 09 Jun 2020 09:50:12 GMT) ==

Improvements:

3% startup_about_home_paint windows7-32-shippable opt e10s stylo 640.29 -> 618.58
3% startup_about_home_paint windows7-32-shippable opt e10s stylo 632.29 -> 613.92

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26162

Comment 7

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 79.0a1 (BuildId:20200619092144) on Windows 10 64bit (Search engines are successfully retrieved from dump first and main-preview after).

Comment 8

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1640136 - Load main dump when using preview r=standard8

Comment 9

[Mathieu Leplatre [:leplatrem]]

Comment on attachment 9165052 [details]
Bug 1640136 - Load main dump when using preview r=standard8

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: In order to backport 1649700 to ESR, we need pieces of this 1640136 (and its follow-up 1644153). We thought it would be cleaner and future-proof to uplift the patch rather than just importing pieces.
• User impact if declined: We would backport 1649700 with a piece of this patch.

For user impact, it means that authors of Remote Settings collections won't be able to preview their changes on top of the default packaged data.

• Fix Landed on Version: 79
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch landed a long time ago, and tests cover the changed part.
• String or UUID changes made by this patch:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9165052 [details]
Bug 1640136 - Load main dump when using preview r=standard8

Approved for 78.1esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/085f163f3fe9