1640153 - Firefox flatpak running instances are not shown with the same icon

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[rasmusnielsen91]

Attachment: Skærmbillede fra 2020-05-22 14-09-10.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

Installed firefox from flathub.
Place the icon in the dock.
Run firefox

Actual results:

Two firefox icons are shown: the beautiful highres one for the launcher. Then a low res one for the actual running process

Expected results:

The launcher should merely show a blue dot underneath as other apps do when an instance of them is running

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Found in triaging. Going forward, Flatpak-related bugs will no longer be filed under RelEng, but instead in Core/Widget:GTK where folks have much more in-depth knowledge on this. If the issues are RelEng related, they can be filed against Release Engineering :: Release Automation: Other and we'll take care of that.

Comment 2

[:Gijs (out for now; he/him)]

From bug 1107281:

(In reply to simsbruno2002 from bug 1107281 comment #4)

It seems StartupWMClass is not present in the .desktop file of the Flatpak version.
Adding StartupWMClass=Firefox in the desktop entry fixes the duplicate icon on Plank & elementaryOS.

I'm confused because https://searchfox.org/mozilla-central/source/toolkit/mozapps/installer/linux/rpm/mozilla.desktop has existed for a long time, but it seems snap and flatpak integration both have their own .desktop files, for reasons that I do not understand.

I'm guessing fixing this is as simple as copying that 1 line from the rpm copy of the .desktop file, but really, it seems like we should have a smarter solution here so there's 1 shared place for shared .desktop stuff that wants going into all these files. :glandium, does that sound right?

Comment 3

[Mike Hommey [:glandium]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1323666#c12

Comment 4

[Mek101]

Attachment: Bug 1640153 - Added StartupWMClass to flatpak .desktop file r?mtabara

Comment 5

[Mek101]

Review ping?

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to support.refragate from comment #5)

Review ping?

r+, will land this on central + beta next week. thanks for the ping, I missed this in my review queue.

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to :Gijs (he/him) from comment #2)

From bug 1107281:

(In reply to simsbruno2002 from bug 1107281 comment #4)

It seems StartupWMClass is not present in the .desktop file of the Flatpak version.
Adding StartupWMClass=Firefox in the desktop entry fixes the duplicate icon on Plank & elementaryOS.

I'm confused because https://searchfox.org/mozilla-central/source/toolkit/mozapps/installer/linux/rpm/mozilla.desktop has existed for a long time, but it seems snap and flatpak integration both have their own .desktop files, for reasons that I do not understand.

Re-reading this, makes a lot of sense for them to share that. I wonder why we went a different route. We either didn't know of that file or maybe the env var passing was different? It's certainly worth exploring that path.

:glandium's https://bugzilla.mozilla.org/show_bug.cgi?id=1323666#c12 makes a lot of sense as well. On the other hand, both Snap and Firefox Flatpak for Snapstore and Flathub are built on Firefox infra and are baking our .desktop files so in this case, they do use the in-tree ones. But I couldn't agree more, we should aim to single-source things into a single place and ease this out.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dc693aa4abd
Added StartupWMClass to flatpak .desktop file r=mtabara DONTBUILD

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2dc693aa4abd

Comment 10

[Mihai Tabara [:mtabara]⌚️GMT]

Closing loop, this started riding the beta trains this week.

Comment 11

[marco4mp]

Hi! With Firefox 99 (Flatpak) this issue has appeared again. :(

Comment 12

[:Gijs (out for now; he/him)]

(In reply to marco4mp from comment #11)

Hi! With Firefox 99 (Flatpak) this issue has appeared again. :(

Please file a new bug with more details. Commenting in old closed bugs doesn't help.

Comment 13

[soljanka]

I created a new bug for this issue, see https://bugzilla.mozilla.org/show_bug.cgi?id=1770636