Closed Bug 1640195 Opened 4 years ago Closed 4 years ago

Address UX feedback for non-native widget styling

Categories

(Core :: Widget, defect, P2)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

Details

Attachments

(2 files)

I'm filing this bug so that we have a bug number to associate with a patch that addresses the latest round of UX feedback. I will be going through our backlog of bugs and close some as dupes of this bug, since it made sense to address all the UX feedback in one go and in one place. The UX feedback is captured here:

https://mozilla.invisionapp.com/share/5CX2MH6EHFB#/screens/415584863_Form_Widgets

This UX update also blocks Linux NNT (bug 1411425).

Blocks: linux-nnt
Pushed by spohl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4fbc6775e743
Address UX feedback for non-native widget styling. r=geckoview-reviewers,emilio,agi
Blocks: 1656264
Pushed by spohl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b672d4b8a21
Address UX feedback for non-native widget styling. r=geckoview-reviewers,emilio,agi
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
--- a/widget/nsNativeBasicTheme.h
+++ b/widget/nsNativeBasicTheme.h
@@ -2,23 +2,107 @@
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #ifndef nsNativeBasicTheme_h
 #define nsNativeBasicTheme_h
 
+#include "mozilla/StaticPrefs_layout.h"
+#include "mozilla/ClearOnShutdown.h"
+#include "mozilla/dom/HTMLMeterElement.h"
+#include "mozilla/dom/HTMLProgressElement.h"
+#include "nsColorControlFrame.h"
+#include "nsDateTimeControlFrame.h"
+#include "nsDeviceContext.h"
 #include "nsITheme.h"
+#include "nsMeterFrame.h"
 #include "nsNativeTheme.h"
+#include "nsProgressFrame.h"
+#include "nsRangeFrame.h"
+
+using namespace mozilla;
+using namespace mozilla::gfx;

Hey, we're not supposed to put using declarations in headers, can you please take care of that in a followup?

I believe the using declarations in headers here broke my local linux builds.

Regressions: 1656471
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c97e499d4bbf
Remove using namespace from nsNativeBasicTheme.h. r=nical
Flags: needinfo?(spohl.mozilla.bugs)
Blocks: 1657743
Regressions: 1657829
Blocks: 1660813
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: