1640217 - Find will not find text if entered with diacritics ("nikud") in Hebrew for PDF viewer

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[eyal gruss]

trying to find הספר with match diacritics turned off does not find הַסֵּפֶר in the following pdf:

https://www.machonso.org/uploads/images/%D7%95%D7%95%D7%9C%D7%A3.pdf

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:bdahl, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Yuri]

Any update on this? I've the same issue with Greek text. I now have to use Chrome just for this... :(

Comment 3

[jtorino]

Chiming in with my experience with PDF, search and diacritics which isn't exactly the same as what OP describes but surely related. In my case it's Spanish language so it's for á é í ó & ú. Basically search in this case is always diacritic-sensitive regardless of whether "Match Diacritic" is set on or off.

Example PDF: https://es.wikipedia.org/api/rest_v1/page/pdf/Ejemplo

Searching for "retórica" does find matches (contrary to OP's Hebrew experience if I understand correctly) but searching for "retorica" never matches even when it should (with Match Diacritic = off).

Comment 4

[Calixte Denizet (:calixte)]

I proposed a patch upstream:
https://github.com/mozilla/pdf.js/pull/13261
:eyaler, I tested with your pdf and it seems ("seem" because I don't read hebrew) to work fine.

Comment 5

[Kenan]

eyal gruss, can you verify that the bug is solved in a current Firefox release?

Comment 6

[Calixte Denizet (:calixte)]

The patch I worked on is still a wip and so has never landed.
Consequently, there are no chance this bug is fixed.

Comment 7

[BMO Automation]

Attachment: [mozilla/pdf.js] Ignore position of combining diacritics when getting text (bug 1640217) (#16033)