Closed Bug 1640278 Opened 2 months ago Closed 14 days ago

Check run-on-projects values

Categories

(Firefox Build System :: Task Configuration, task)

task

Tracking

(firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: Sylvestre, Assigned: Callek)

References

Details

Attachments

(4 files)

We don't perform any verification on the run-on-projects values

In at least two cases, we had some issues which were undetected.
bug 1627424 & https://bugzilla.mozilla.org/show_bug.cgi?id=1638260#c8

Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED

This is in-part a followup to 1638260 which fixed some cases of this problem.

Pushed by jwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27ae032f17be
Do validation of run-on-projects. r=catlee
https://hg.mozilla.org/integration/autoland/rev/dbf1e5788c22
Fixup run-on-projects verification failures. r=sylvestre
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e63b60fe21fe
Fix bustage because empty {} is a dict not a set CLOSED TREE

Backed out 3 changesets (bug 1640278) for verify lint failure

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunning%2Cpending%2Crunnable&fromchange=dbf1e5788c2210c72006d77a5a840a3dd41afa2f&tochange=c6b49f0f97d9c60764ee20231589387b92c6adf3&selectedTaskRun=SDnJT8TyTJWTKv4Daz-krQ-0

Backout link: https://hg.mozilla.org/integration/autoland/rev/c6b49f0f97d9c60764ee20231589387b92c6adf3

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305260120&repo=autoland&lineNumber=116

[task 2020-06-05T19:52:31.008Z] 19:52:31.8 flake8 (101) | Command: --config /builds/worker/checkouts/gecko/.flake8 --output-file /tmp/tmp5h6kir10 --format {"path":"%(path)s","lineno":%(row)s,"column":%(col)s,"rule":"%(code)s","message":"%(text)s"} --filename *.configure,*.py
[task 2020-06-05T19:52:43.150Z] 19:52:43.149 flake8 (102) | Finished in 12.36 seconds
[task 2020-06-05T19:52:56.923Z] 19:52:56.923 flake8 (104) | Finished in 26.13 seconds
[task 2020-06-05T19:53:31.363Z] 19:53:31.363 flake8 (103) | Finished in 60.57 seconds
[task 2020-06-05T19:53:36.072Z] 19:53:36.72 flake8 (101) | Finished in 65.28 seconds
[task 2020-06-05T19:53:36.079Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/taskcluster/taskgraph/util/verify.py:368:11 | multiple spaces after keyword (E271)
[taskcluster 2020-06-05 19:53:36.361Z] === Task Finished ===
[taskcluster 2020-06-05 19:53:37.029Z] Unsuccessful task run with exit code: 1 completed in 92.941 seconds
Flags: needinfo?(bugspam.Callek)

Depends on D76746

This could go further and test for m-c or the trunk/integration aliases, etc. but I opted for not letting this increase try-syntax jobs.

Depends on D81755

Pushed by jwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aabff19fe35d
Do validation of run-on-projects. r=catlee
https://hg.mozilla.org/integration/autoland/rev/31f6b0405b11
Fixup run-on-projects verification failures. r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/1a9f74ca35af
Adjust docs. r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/9898f1958c7c
Remove 'try' from checking run-on-projects for try-syntax. r=bhearsum
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/9e21e4f7e980
Port bug 1640278 - Remove 'try' from checking run-on-projects for try-syntax. rs=bustage-fix
Flags: needinfo?(bugspam.Callek)
You need to log in before you can comment on or make changes to this bug.