Closed Bug 1640318 Opened 3 years ago Closed 3 years ago

Disabling JavaScript still applies to all tabs after DevTools close


(DevTools :: Debugger, defect, P2)



(firefox-esr68 unaffected, firefox76 unaffected, firefox77 wontfix, firefox78 fixed)

Firefox 78
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- unaffected
firefox77 --- wontfix
firefox78 --- fixed


(Reporter: Harald, Assigned: davidwalsh)




(Keywords: dev-doc-complete, regression)


(1 file)

What were you doing?

  1. Open DevTools on Debugger
  2. Check Disable JavaScript in the settings menu.
  3. Close DevTools

What happened?

JS doesn't work in any tab. Debugger has to be opened again and the option unchecked.

What should have happened?

Disabling JS only affects the current tab and is reset when DevTools closes, similar to Disable Cache.

Anything else we should know?

This can be a massive footgun for developers. I marked this regression as the option is much easier to find now and can surprise more developers.

The root cause is that the new Debugger settings menu does toggle the global javascript.enabled setting. The existing Disable JavaScript in Settings sets a docShell specific flag which gets reset when DevTools closes (and also handles refresh on toggle).

Honza, David, Jason, any ideas if this can be fixed in 78, maybe uplifted to 77?

Flags: needinfo?(odvarko)
Flags: needinfo?(jlaster)
Flags: needinfo?(dwalsh)

@honza @jlast Could you provide a bit of guidance to help me get this updated quickly? I've not worked with docShell before!

Flags: needinfo?(dwalsh)
Flags: needinfo?(dwalsh)

Yes, that works, working on a patch now!

Flags: needinfo?(dwalsh)
Assignee: nobody → dwalsh

Set release status flags based on info from the regressing bug 1630957

Keywords: dev-doc-needed
Pushed by
Disable only JavaScript in the present tab when using the debugger menu r=jlast
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78

Updated the UI Tour to reflect the corrected behavior.

Flags: needinfo?(odvarko)
Flags: needinfo?(jlaster)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.