1640338 - Remove accessibility-startup.

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, task)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

With potentially switching to auto initialization of the accessibility panel, accessibility startup becomes more irrelevant. We don't really need to know if the accessibility service is running or not since it will always startup if the panel opens (seamlessly).

This will also help with the overhead of the tool startup API that toolbox tools have which only accessibility panel uses at the moment. It can be removed completely.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1640338 - remove accessibliity startup and startup functionality from tool definitions. r=ochameau

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1640338 - simplify accessibility proxy startup since we no longer need to initialize it until the panel is opened. r=mtigley

Depends on D77055

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1640338 - do not cache current target on proxy accessible, instead always retrieve toolbox's target list's targetFront. r=ochameau

Depends on D77056

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2394d79f48f
remove accessibliity startup and startup functionality from tool definitions. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/cb4edb2627bb
simplify accessibility proxy startup since we no longer need to initialize it until the panel is opened. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/6401dd804f28
do not cache current target on proxy accessible, instead always retrieve toolbox's target list's targetFront. r=ochameau

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ff626b72199
Backed out 4 changesets (bug 1640338, bug 1640778) for devtools failures on browser_dbg-toolbox-unselected-pause.js.

Comment 6

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=92cb02f03119f08436bef03d2aa821ab5c974bb6&searchStr=%28dt&selectedTaskRun=LyIvN4aPTl2ArMYJUrNufA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=308032746&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/47f18d1138df7f10a4d6a0a92d00e5b7cfc8ca42

[task 2020-06-30T16:02:39.948Z] 16:02:39     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-toolbox-unselected-pause.js | Debugger selected - 
[task 2020-06-30T16:02:39.949Z] 16:02:39     INFO - Console message: [JavaScript Warning: "debuggee 'resource://devtools/shared/base-loader.js:289' would run" {file: "resource://devtools/shared/builtin-modules.js" line: 180}]
[task 2020-06-30T16:02:39.949Z] 16:02:39     INFO - Buffered messages logged at 16:02:38
[task 2020-06-30T16:02:39.949Z] 16:02:39     INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/NetUtil.jsm" line: 253}]
[task 2020-06-30T16:02:39.949Z] 16:02:39     INFO - Buffered messages logged at 16:02:39
[task 2020-06-30T16:02:39.949Z] 16:02:39     INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/NetUtil.jsm" line: 253}]
[task 2020-06-30T16:02:39.949Z] 16:02:39     INFO - Buffered messages finished
[task 2020-06-30T16:02:39.950Z] 16:02:39     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-toolbox-unselected-pause.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/framework/browser-toolbox/test/helpers-browser-toolbox.js:139 - Error: ToolboxTask.spawn await rejected
[task 2020-06-30T16:02:39.950Z] 16:02:39     INFO - Stack trace:
[task 2020-06-30T16:02:39.950Z] 16:02:39     INFO - spawn@chrome://mochitests/content/browser/devtools/client/framework/browser-toolbox/test/helpers-browser-toolbox.js:139:13
[task 2020-06-30T16:02:39.950Z] 16:02:39     INFO - async*@chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg-toolbox-unselected-pause.js:47:21
[task 2020-06-30T16:02:39.950Z] 16:02:39     INFO - Leaving test bound 
[task 2020-06-30T16:02:39.950Z] 16:02:39     INFO - GECKO(8976) | J
[task 2020-06-30T16:02:39.950Z] 16:02:39     INFO - Removing tab.
[task 2020-06-30T16:02:39.951Z] 16:02:39     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-06-30T16:02:39.951Z] 16:02:39     INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-06-30T16:02:39.951Z] 16:02:39     INFO - Tab removed and finished closing
[task 2020-06-30T16:02:39.951Z] 16:02:39     INFO - GECKO(8976) | JavaScript error: resource://devtools/server/actors/highlighters.js, line 751: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXPCComponents_Utils.isDeadWrapper]
[task 2020-06-30T16:02:39.952Z] 16:02:39     INFO - GECKO(8976) | avaScript error: debugger eval code, line 7: TypeError: gToolbox.isToolHighlighted is not a function
[task 2020-06-30T16:02:39.990Z] 16:02:39     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-toolbox-unselected-pause.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2020-06-30T16:02:39.990Z] 16:02:39     INFO - Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXPCComponents_Utils.isDeadWrapper]" {file: "resource://devtools/server/actors/highlighters.js" line: 751}]
[task 2020-06-30T16:02:39.990Z] 16:02:39     INFO - get window@resource://devtools/server/actors/highlighters.js:751:15
[task 2020-06-30T16:02:39.990Z] 16:02:39     INFO - get document@resource://devtools/server/actors/highlighters.js:755:5
[task 2020-06-30T16:02:39.990Z] 16:02:39     INFO - _insert@resource://devtools/server/actors/highlighters/utils/markup.js:272:17
[task 2020-06-30T16:02:39.990Z] 16:02:39     INFO - enter@resource://devtools/server/actors/utils/event-loop.js:79:18
[task 2020-06-30T16:02:39.990Z] 16:02:39     INFO - _pushThreadPause@resource://devtools/server/actors/thread.js:326:15
[task 2020-06-30T16:02:39.991Z] 16:02:39     INFO - _pauseAndRespond@resource://devtools/server/actors/thread.js:893:12
[task 2020-06-30T16:02:39.991Z] 16:02:39     INFO - onDebuggerStatement@resource://devtools/server/actors/thread.js:1885:17
[task 2020-06-30T16:02:39.991Z] 16:02:39     INFO - @data:text/html,<script>debugger;</script>:1:1
[task 2020-06-30T16:02:39.991Z] 16:02:39     INFO - 
[task 2020-06-30T16:02:40.040Z] 16:02:40     INFO - GECKO(8976) | MEMORY STAT | vsize 2104682MB | vsizeMaxContiguous 66083117MB | residentFast 472MB | heapAllocated 159MB

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a0fa4ee39e7
remove accessibliity startup and startup functionality from tool definitions. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/06a66e64c884
simplify accessibility proxy startup since we no longer need to initialize it until the panel is opened. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/83fc983a6c07
do not cache current target on proxy accessible, instead always retrieve toolbox's target list's targetFront. r=ochameau

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2a0fa4ee39e7
https://hg.mozilla.org/mozilla-central/rev/06a66e64c884
https://hg.mozilla.org/mozilla-central/rev/83fc983a6c07