1640387 - PanZoomController might erroneously return INPUT_RESULT_HANDLED in some cases

Status: RESOLVED FIXED

(GeckoView :: IME, task)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1631754 +++

Per the discussion at https://bugzilla.mozilla.org/show_bug.cgi?id=1633322#c5 onwards, we should only be setting mTargetIsRoot in the cases where we know for sure the event was handled by the root content APZ. Botond identified this as a potential problem in this bug comment as well.

I have patches to fix this. It will likely make bug 1633322 slightly worse in that you'll have more cases of the URL bar appearing even though the toplevel content is actually being scrolled. I don't expect it to happen much more often, but it might.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=ee60ffd3c9aa95842af59c96ac8d2413de3a066a

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1640387 - Combine a few loose fields in APZCTreeManager into a HitTestResult. r?botond

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1640387 - Only set HitResult::mTargetIsRoot for confirmed-root targets. r=snorp!,botond!

Depends on D76593

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d73ccaaccd2
Combine a few loose fields in APZCTreeManager into a HitTestResult. r=botond
https://hg.mozilla.org/integration/autoland/rev/5cf3ae77ccb3
Only set HitResult::mTargetIsRoot for confirmed-root targets. r=snorp,botond

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9d73ccaaccd2
https://hg.mozilla.org/mozilla-central/rev/5cf3ae77ccb3

Comment 8

[Chris Peterson [:cpeterson]]

Moving some input bugs to the new GeckoView::IME component.