1640425 - chromestatus.com is broken on Nightly

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P1)

Description

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

1. Access https://www.chromestatus.com/metrics/feature/timeline/popularity/1027
2. Check "Adoption of the feature on top sites" loads

Expected: It should
Actual: It does not and the loading indicator runs infinitely.

The first broken build is 2020-02-10.

Comment 1

[Alice0775 White]

If you add this website to the ETP exception, the page seems to load as expected.

Comment 2

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Here is the regression range made on Windows 10x64:
Last good revision: 1ece26f610490b707948f20fe1230dbe306ef985 (2020-02-09)
First bad revision: 813768d074e3accc36dc3313d0bffb658dcc562d (2020-02-10)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1ece26f610490b707948f20fe1230dbe306ef985&tochange=813768d074e3accc36dc3313d0bffb658dcc562d

When bisecting it further I get this pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4c08723ed20aec9a60d09247ba7ff0ed2beb62aa&tochange=d3aa4a9e4dfd20e2be232a415a705a250aa17f63 and when switching to autoland I get this error: ERROR: Unable to exploit the merge commit. Origin branch is mozilla-central, and the commit message for d3aa4a9e was: Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release

Comment 3

[Steven Englehardt [:englehardt]]

This is the same issue described in Bug 1631811 Comment 1. This should only be broken in Nightly.

Comment 4

[Steven Englehardt [:englehardt]]

Since chromestatus seems to be a Google website we can fix this through the entity list. I've filed https://github.com/disconnectme/disconnect-tracking-protection/issues/183 to request that and will update this bug if/when we ship a fix.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:englehardt, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 6

[Steven Englehardt [:englehardt]]

Since this is was broken by tracking protection it's not a regression. We'll merge a fix to the entitylist tomorrow via https://github.com/mozilla-services/shavar-prod-lists/pull/199.

Comment 7

[Steven Englehardt [:englehardt]]

This was fixed by https://github.com/mozilla-services/shavar-prod-lists/pull/199. Existing profiles may take a little while to get the newest version of the blocklist.