Closed Bug 1640572 Opened 5 years ago Closed 5 years ago

Add error boundary to EagerEvaluation component

Categories

(DevTools :: Console, task, P2)

task

Tracking

(firefox78 fixed)

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(1 file)

When chasing Bug 1640140, I tried to reproduce by typing in the console input, and made the eager evaluation (and the whole console crash)
We should have error boundaries in place on this component to make sure we don't crash the console.

Summary: Add a componentDidThrow method to EagerEvaluation component → Add error boundary to EagerEvaluation component

This will prevent the Eager Evaluation component to crash the whole console
when there's an issue in its render function.

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/000aac572ccf Add Error boundaries to Eager Evaluation component. r=bomsy.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: