1640578 - Mac Artifact builds on try server are no longer possible

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

I've been trying to do some artifact builds on try server, and they fail with

[task 2020-05-24T23:02:06.449Z] 23:02:06     INFO -  mozbuild.configure.options.InvalidOptionError: --disable-install-strip is not available in this configuration

The best I can tell at the moment, is that this is likely to be a regression from bug 1639815.

Example Runs:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=K-mDNeYlRd-q3Zl4eZTl4g-0&revision=650738b712b6e83c0d1e77d10f113bdc27f98072
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fd9e80597e1e97ed0b0ef61525519677708449f

Comment 2

[:Gijs (he/him)]

If we could fix this by making artifact builds on try on macOS actually artifact builds and skip the instr/run steps, that'd be great... (cf. bug 1619966)
Right now those tests finish significantly later than the windows/linux ones because those don't need to do a "real" build...

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1639815

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1640578 - Remove --disable-install-strip from mac mozconfigs.

The need for --disable-install-strip in the mac mozconfigs comes from a
discrepancy in how stripping is handled between platforms. On Windows,
there is no stripping. On non-Mac unix, strip removes local symbols as
well as debug info and symbols. On Mac, it actually removes too much,
and one has to pass flags to remove both local symbols (-x) and debug
symbols (-S). Debug info is already in a separate file (.dSYM).

For profiling reasons, we do ship e.g. nightlies with local symbols but
not debug info or symbols (or at least that's the intent). On Windows,
again, nothing to do. On non-Mac unix, we pass --strip-debug to
strip so that it keeps local symbols. That's where the discrepancy
comes in for Mac: the build system doesn't handle this at all, so the
mozconfigs contain --disable-install-strip to avoid stripping.

The build system should be doing what it's expected to be doing from the
start, without mozconfigs opting into anything.

AFAIK, we only really need the local symbols, so we can strip -S on
Mac when profiling is enabled, rather than strip -x -s. This also
significantly reduces the size of the installer for nightlies.

And while we're here, move the logic out of old-configure and into
python configure.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fae8aeba1a70
Remove --disable-install-strip from mac mozconfigs. r=froydnj

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fae8aeba1a70