1640580 - mach try auto doesn't schedule web platform tests

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, defect, P1)

Description

[Simon Giesecke [:sg] [he/him]]

I recently did several mach try auto pushes with local changes to dom/indexedDB/*.cpp files, e.g. https://treeherder.mozilla.org/#/jobs?repo=try&revision=210a4bf8a8856ecde6ef0167f33679db93b87ec0&selectedTaskRun=aIdpalNyRgamfIvS7xksAA-0

This seems to run the relevant mochitest and xpchshell-test test suites, but it failed to select the /IndexedDB/ web platform tests.

Comment 1

[Andrew Halberstadt [:ahal]]

Thanks for filing!

I see the ML selected testing/web-platform/tests/indexedDB with 94% confidence. In fact it selected other WPT manifests with 99% confidence, yet no tasks were run. So this is a problem with the taskgraph code rather than the ML algorithm.

I'd guess it's a regression either from bug 1608837 or a change to bugbug. Marco, did you end up landing that change where you were returning the full path from bugbug rather than the ids? Looks like the group names are mismatching.

Comment 2

[Andrew Halberstadt [:ahal]]

Oh, looks like you did (duh, I was looking right at the line that gave me the answer). Ok, in that case not a regression from bug 1608837. In fact we have bug 1638429 filed to handle this change already, but we never ended up coordinating on the landing. I'll just dupe that here.

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1640580 - [taskgraph.util.bugbug] Translate WPT paths from relative source directory to WPT ids, r?marco

Comment 5

[Andrew Halberstadt [:ahal]]

I tested the above patch out by rebasing Simon's patch on top of my fix:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f489ebac861a22793d95b000dea4048846b4688c

I didn't let the tasks finish running to save resources, but we are clearly scheduling wpt tasks again (whereas on the push in comment 0 we weren't).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc5a758cb608
[taskgraph.util.bugbug] Translate WPT paths from relative source directory to WPT ids, r=marco

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dc5a758cb608