1640601 - Assert when toggling `display` back from none in ::file-chooser-button.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

MOZ_ASSERT(aChild->GetProperty(nsGkAtoms::restylableAnonymousNode)) (Someone passed native anonymous content directly into frame construction.  Stop doing that!)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1640601 - Also reframe the closest non-anonymous root when switching anonymous content from display: none to something else. r=mats,jwatt

We were dealing with it correctly when switching display from e.g. block
to inline, or such. But we were not dealing with it when the node was
undisplayed.

Handle it properly, and free one frame bit while at it. We can't really
do this for ManualNAC (the editor resizers) because they request a
reframe explicitly.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a74484fbd880
Also reframe the closest non-anonymous root when switching anonymous content from display: none to something else. r=mats

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23763 for changes under testing/web-platform/tests

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a74484fbd880

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot