1640673 - Add ability to filter pushes by commit message

Status: NEW

(Tree Management :: Treeherder: Frontend, enhancement)

Description

[Andrew Halberstadt [:ahal]]

Lately I find myself perusing through try to look for pushes made by |mach try auto|. I'd like a visual view of which tasks are being selected by our tool.

Unfortunately try is dominated by reviewbot, and I need to sift through 100s of pushes to find just a handful of |mach try auto| ones.

It would be great if we could apply a filter that uses the commit message to select pushes (similar to the author filter). I would be totally happy if this was a "secret" feature that only existed in the URL and had no treeherder UI.

A related request would be to allow author negation (i.e, remove all pushes by "reviewbot"), but it would be totally unnecessary for my use case if we could filter on the commit message.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think negating authors would just be doing something extra in https://github.com/mozilla/treeherder/blob/96bf8370e1fd9fb46f4098582bc07065c51fd36f/treeherder/webapp/api/push.py#L144-L146

Email addresses aren't legally allowed to start with a hyphen, right? So it could probably be as easy as just getting the author value and if it starts with a hyphen, strip the hyphen and filter()exclude() for all of the pushes that do NOT have the matching author.

EDIT: exclude() is the opposite of filter()

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: GitHub Pull Request

This pull request adds negation to the author filter. If you prefix the author email address with a hyphen, it should show you all pushes in the given range that are not from that author.

The backend tests pass, so I'm pretty sure this works, but I'm having trouble with my local treeherder dev environment, so I haven't actually been able to run the front and backend to see how it works in the UI.