1640718 - Search query not restored on onliner.by

Status: NEW

(Firefox :: Session Restore, defect, P2)

Description

[Jan Henning [:JanH]]

If you go to https://www.onliner.by and start typing something in the search box, then close the tab and subsequently restore it, the search query is no longer restored.

Interestingly enough, it seems that the regression happened in two parts:

Originally, everything worked fine. If you changed the search query in the restored tab and closed and restored it again, the changed search query would also be restored properly.
From a certain point onwards [1], only the first few characters you typed would get restored. If you subsequently modified that partially restored search query, this would be ignored - closing and restoring the tab would only restore the partial search query from the first time round.
And eventually things stopped working completely, i.e. the query is no longer restored at all [2].

This issue affects both Desktop and mobile, i.e. it works both in old Desktop and Fennec builds, and it doesn't work in current Desktop or Fenix builds.

[1] https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=52285ea5e54c73d3ed824544cef2ee3f195f05e6&tochange=fa1da3c0b200abbd9cfab3cab19962824314044e
[2] https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1312db5d495953cc6e18b16d082d06d611a21166&tochange=1db2248f441513991df17a73112ffd9cc1846846

Comment 1

[Jan Henning [:JanH]]

From those two regression ranges, bug 1373672 looks like the prime suspect for [1], and bug 1497146 for [2].

Comment 2

[Alphan Chen [:alchen]]

The problem is caused by this line.
https://searchfox.org/mozilla-central/rev/ea7f70dac1c5fd18400f6d2a92679777d4b21492/toolkit/components/sessionstore/SessionStoreUtils.cpp#622
The search element is not "AutoCompleteEnabled".
That's why we don't collect the value of this element.

This line is implemented in the original file as below.
https://searchfox.org/mozilla-central/rev/5d28867416abcb0d586fe3904ff0d5b7630e80db/toolkit/modules/sessionstore/FormData.jsm#42-53

In this case, it looks like that we cannot get the same result by "nsContentUtils::IsAutocompleteEnabled(node) in cpp" and "node.autocomplete in JSM".

Peter and Mike, what do you think?

Comment 3

[Alphan Chen [:alchen]]

Attachment: search_element@Onliner

Use developer tools to check the element.

Comment 4

[Tim Spurway [:tspurway]]

S1 or S2 bugs need an assignee - could you find someone for this bug?

Comment 5

[Alphan Chen [:alchen]]

(In reply to Alphan Chen [:alchen] from comment #3)

Created attachment 9151719 [details]
search_element@Onliner

Use developer tools to check the element.

Since the input element is inside the form element, I think the input element should also have the same attribute. (autocomplete =off)

Comment 6

[janet [:janet]]

Marking this as S3 as it appears that S2 (Serious) Major functionality/product severely impaired - is not the correct severity here. Please update if this is incorrectly categorized.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:dao, since the bug has high priority, could you have a look please?

For more information, please visit auto_nag documentation.