1640734 - Frequency capping should apply separately for production and experiment messages

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement)

Description

[Andrei Oprea [:andreio]]

CFRs and experimental CFRs should count towards separate quotas: seeing a production CFR shouldn't keep someone from experiencing an experiment and vice versa.
Doc: https://docs.google.com/document/d/1_tbbKtrQZltxZzGYmw4Y9KRp97JVJ223AlhkdBYft8o/edit#

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1640734 - Frequency capping should apply separately for production and experiment messages

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e0971e05ec0
Frequency capping should apply separately for production and experiment messages r=k88hudson

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 9e0971e05ec0 (bug 1640734) for Browser-chrome failures in browser/components/newtab/test/browser/browser_asrouter_group_frequency.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304310594&repo=autoland&lineNumber=2398

Newtab failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=215445cf1387c879d23af42e34283d26b33bf5dd&selectedTaskRun=T-grYuQ1RhqSXxNwgUVw6A-0

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=9e0971e05ec02af35917176c3fffc5b17f8fa82b

Backout:
https://hg.mozilla.org/integration/autoland/rev/44c8d7a750a1a3e773278de71d8f898c278426f8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e7dbd18dcbb
Frequency capping should apply separately for production and experiment messages r=k88hudson

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/233196e86939
Backed out changeset 9e7dbd18dcbb for newtab failures. CLOSED TREE

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for newtab failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/233196e86939e937728f2b8e81277e548cc2844e
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304758267&repo=autoland&lineNumber=512

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9e7dbd18dcbb

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/233196e86939

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/952bcd54fdff
Frequency capping should apply separately for production and experiment messages r=k88hudson

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/952bcd54fdff

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that two CFR messages, a production one and an experiment one can be triggered on the same day. In order to do that I've changed the environment to the "Stage" server, I've triggered the "HEARTBEAT_TACTIC_2" CFR message and I've navigated to the "netflix.com" website where the "N4S_PIP_CFR_MESSSAGE" CFR experiment message was displayed.

Verified using the latest Firefox Nightly (79.0a1 Build ID - 20200605043926) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.