1640765 - Limit the experimental rust fxa client to Nightly

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, enhancement)

Description

[Ryan Kelly [:rfkelly]]

Bug 1631630 landed the fxa-client rust crate and some JS bindings, as prep work for doing an incremental replacement of the current javascript client with some shared Rust code. Bug 1638763 notes a non-trivial increase in installer size as a result of this landing, which we expect to be a temporary situation until we're ready to remove the old code. To avoid paying this cost without any visible user benefit in the meantime, I think it would be worth our while to restrict the rust fxa-client create to Nightly only, at least until the "incremental replacement" plan is well under way.

Patch incoming.

Comment 1

[Ryan Kelly [:rfkelly]]

Attachment: Bug 1640765 - only build the rust fxa-client crate on Nightly. r?lina

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d3f76ede294
only build the rust fxa-client crate on Nightly. r=lina

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 0d3f76ede294 (bug 1640765) for rust related bustage

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=0d3f76ede294eac600139a1c94f329786d312629&tochange=1206db868352952ae2a93ce4b5c555036cbe1e30&searchStr=build&selectedTaskRun=KsVPD1dMR-ay3HykvGeeiA-0

Backout link: https://hg.mozilla.org/integration/autoland/rev/1206db868352952ae2a93ce4b5c555036cbe1e30

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303883263&repo=autoland&lineNumber=6170

[task 2020-05-27T03:58:43.855Z] 03:58:43     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/library/gtest/rust'
[task 2020-05-27T03:58:43.855Z] 03:58:43     INFO -  toolkit/library/gtest/rust/force-cargo-library-build
[task 2020-05-27T03:58:43.855Z] 03:58:43     INFO -  /builds/worker/fetches/rustc/bin/cargo rustc  --frozen --manifest-path /builds/worker/checkouts/gecko/toolkit/library/gtest/rust/Cargo.toml -vv --lib --target=x86_64-unknown-linux-gnu --features 'gecko_debug gecko_refcount_logging quantum_render webgpu cubeb_pulse_rust simd-accel cubeb-remoting moz_memory moz_places spidermonkey_rust cranelift_x86 gecko_profiler gecko_profiler_parse_elf new_xulstore new_cert_storage webrtc remote_agent glean rust_fxa_client wasm_library_sandboxing' --
[task 2020-05-27T03:58:43.856Z] 03:58:43     INFO -  error: Package `gkrust-gtest v0.1.0 (/builds/worker/checkouts/gecko/toolkit/library/gtest/rust)` does not have these features: `rust_fxa_client`
[task 2020-05-27T03:58:43.856Z] 03:58:43     INFO -  /builds/worker/checkouts/gecko/config/makefiles/rust.mk:293: recipe for target 'force-cargo-library-build' failed
[task 2020-05-27T03:58:43.856Z] 03:58:43    ERROR -  make[4]: *** [force-cargo-library-build] Error 101
[task 2020-05-27T03:58:43.856Z] 03:58:43     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/library/gtest/rust'
[task 2020-05-27T03:58:43.856Z] 03:58:43     INFO -  /builds/worker/checkouts/gecko/config/recurse.mk:74: recipe for target 'toolkit/library/gtest/rust/target' failed
[task 2020-05-27T03:58:43.856Z] 03:58:43    ERROR -  make[3]: *** [toolkit/library/gtest/rust/target] Error 2
[task 2020-05-27T03:58:43.856Z] 03:58:43     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2020-05-27T03:58:43.856Z] 03:58:43     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/js/src/jsapi-tests'

Comment 4

[Ryan Kelly [:rfkelly]]

Ugh, thanks. This built fine locally for me even though it really shouldn't have, so I've made sure to push to try and check that all builds passed before resubmitting.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71a05993c9bd
only build the rust fxa-client crate on Nightly. r=lina

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/71a05993c9bd