1640883 - execCommand('copy') denied on CTRL-X and CTRL-C

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Edgar Chen [:edgar]]

This is originally reported on https://github.com/eclipse-theia/theia/issues/7542.

It is because we don't treat the key event come with the modifier as a user activation, see https://searchfox.org/mozilla-central/rev/e9131060a0322f6c181b4933ac74e6440b6e723d/widget/TextEvents.h#320. But the Ctrl-x, Ctrl-C is a quite common shortcut for copying, I think we should allow it.

And the reason for ignoring key events with a modifier is mainly because we think the user might intend to interact with the browser at that time. We should have a better way to handle it instead of ignoring all combinations.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1640883 - Treat ctrl-c, ctrl-x and ctrl-v as user activation;

ctrl-c and ctrl-x is quite common shortcut for clipboard operation, we should
treat it as user activaion.

Comment 2

[anton.kosyakov]

Is there a workaround for it?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa89e2840bce
Treat ctrl-c, ctrl-x and ctrl-v as user activation; r=smaug

Comment 4

[Edgar Chen [:edgar]]

(In reply to anton.kosyakov from comment #2)

Is there a workaround for it?

Unfortunately, there is no workaround for web content.

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset aa89e2840bce (Bug 1640883) for causing failures in test_autoplay_policy_key_blacklist.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=dkY4GZlOTzqnt9tHPDr2zg-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=aa89e2840bce71cb87b0ec605be5d8534256ac18

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304132050&repo=autoland&lineNumber=2061

Backout: https://hg.mozilla.org/integration/autoland/rev/71a9976f5ea6fee1c7e2fdde46e83011e32712b3

Comment 6

[Edgar Chen [:edgar]]

Attachment: Bug 1640883 - Update autoplay policy tests;

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2d2e86a99d0
Treat ctrl-c, ctrl-x and ctrl-v as user activation; r=smaug
https://hg.mozilla.org/integration/autoland/rev/e7c7162dbee2
Update autoplay policy tests; r=alwu

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f2d2e86a99d0
https://hg.mozilla.org/mozilla-central/rev/e7c7162dbee2