Closed Bug 1640927 Opened 4 years ago Closed 4 years ago

Can't upgrade glean_core because of miniz_sys weirdness.

Categories

(Toolkit :: Telemetry, task, P1)

Product:
Toolkit
Component:
Telemetry
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: chutten, Assigned: janerik)

References

Details

(Whiteboard: [telemetry:fog:m3])

Attachments

(2 files)

Link to GitHub pull-request: https://github.com/mozilla/glean/pull/921
41 bytes, text/x-github-pull-request
Details | Review
Bug 1640927 - Upgrade glean-core to v31.0.2 r?chutten!
47 bytes, text/x-phabricator-request
Details | Review

I tried upgrading glean_core to 30.1.0 and m-c wouldn't compile for me because flate2 couldn't find miniz_sys. It didn't have that problem before the upgrade.

Leading theory at the moment is that since glean_core uses flate2 without miniz_sys but m-c does (possibly transitively from object crate) that wires are getting crossed.

Assignee: nobody → jrediger
Priority: P3 → P2
Blocks: 1623304
Whiteboard: [telemetry:fog:m?] → [telemetry:fog:m3]
Priority: P2 → P1

This gets us default gzip compression on ping sending.

Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b07e6fa048c Upgrade glean-core to v31.0.2 r=chutten

https://hg.mozilla.org/mozilla-central/rev/2b07e6fa048c

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: