1640983 - rust 1.45 must-use error about mem::replace in webrender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[(Away)]

1:16.17 error: unused return value of `std::mem::replace` that must be used
 1:16.17     --> gfx\wr\webrender\src\renderer.rs:2764:29
 1:16.17      |
 1:16.17 2764 | / ...                   mem::replace(
 1:16.17 2765 | | ...                       &mut self.active_documents[pos].1,
 1:16.17 2766 | | ...                       doc,
 1:16.17 2767 | | ...                   );
 1:16.17      | |________________________^
 1:16.17      |
 1:16.17      = note: `-D unused-must-use` implied by `-D warnings`
 1:16.17      = note: if you don't need the old value, you can just assign the new value directly
 1:16.17 error: aborting due to previous error
 1:16.18 error: could not compile `webrender`.

Comment 1

[(Away)]

Attachment: Fix a must-use error about mem::replace in renderer.rs

The mem::replace was added in https://hg.mozilla.org/integration/autoland/rev/b2abdbdb7ba238d751dd706d5f506fcb7556b797#l1.12

and obsoleted in https://hg.mozilla.org/integration/autoland/rev/504dfff094f5f3a99837e0287324e746c2f986a1#l6.86

This patch restores the original assignment.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/168ba3892817
Fix a must-use error about mem::replace in renderer.rs r=gw

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/168ba3892817